RT-7.10 Routing policy statement insertion and removal #3578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Functional Test Report for #3578 / 629cc21Virtual Devices
Hardware Devices
|
Pull Request Test Coverage Report for Build 11803964838Details
💛 - Coveralls |
dplore
requested changes
Nov 13, 2024
|
|
||
| ## Summary | ||
|
|
||
| This test verify that using gNMI setReqyest(Replace) we can insert statement in the middle of pre-existing policy, then remove any statement form policy, the re add this statement. |
There was a problem hiding this comment.
Suggested change
| This test verify that using gNMI setReqyest(Replace) we can insert statement in the middle of pre-existing policy, then remove any statement form policy, the re add this statement. | |
| This test verify that using a sequence of gNMI setRequest(Replace) RPC's we can insert a policy statement in the middle of pre-existing policy, then remove a statement from a policy, and then add the previously removed statement back to the policy. |
|
|
||
| ## Subtests | ||
|
|
||
| * RT-7.10.1 Initial Policy |
There was a problem hiding this comment.
Here and throughout, use a level 3 heading for subtests. ie: ### RT-7.10.1 Initial Policy
| } | ||
| } | ||
| ``` | ||
| * Verify that DUT accepted configuration without errors. |
There was a problem hiding this comment.
- Use gnmi Set with REPLACE option. Verify return code is
OK.
| } | ||
| ``` | ||
| * Verify that DUT accepted configuration without errors. | ||
| * Retrive "test-policy" from device using subscribeRequest once for `/routing-policy/policy-definitions/policy-definition[name="test-policy"]/*`. Compare with policy configured above. |
There was a problem hiding this comment.
Use gNMI Get to retrieve the 'config' paths for the above configuration. The gNMI response should match the 'config' paths used in the gNMI Set from the policy above.
| * Retrive "test-policy" from device using subscribeRequest once for `/routing-policy/policy-definitions/policy-definition[name="test-policy"]/*`. Compare with policy configured above. | ||
|
|
||
| * RT-7.10.2 Policy statement insertion | ||
| * Configure policy "test-policy" and apply using setRequest Replace at `openconfig/routing-policy/` |
There was a problem hiding this comment.
Suggested change
| * Configure policy "test-policy" and apply using setRequest Replace at `openconfig/routing-policy/` | |
| * Generate policy "test-policy" and apply using gNMI Set with REPLACE option at `openconfig/routing-policy/` |
| } | ||
| ``` | ||
| * Verify that DUT accepted configuration without errors. | ||
| * Retrive "test-policy" from device using subscribeRequest once for `/routing-policy/policy-definitions/policy-definition[name="test-policy"]/*`. Compare with policy configured above. |
There was a problem hiding this comment.
The generated paths for the Set should match the paths retrieved from the Get exactly. There should be no additions or missing paths.
| * RT-7.10.2 Policy statement insertion | ||
| * Configure policy "test-policy" and apply using setRequest Replace at `openconfig/routing-policy/` | ||
| ``` | ||
| { |
There was a problem hiding this comment.
This would replace the "test_policy" which above has statements 1,3,5,7,9 with a new test_policy containing only statemets 1,2,6,7,8,10. Statements 3,5,9 are omitted, so they would be removed. Is that the intent?
(likewise the community-sets are also affected)
| * Retrive "test-policy" from device using subscribeRequest once for `/routing-policy/policy-definitions/policy-definition[name="test-policy"]/*`. Compare with policy configured above. | ||
|
|
||
| * RT-7.10.3 Policy statement removal | ||
| * Configure policy "test-policy" and apply using setRequest Replace at `openconfig/routing-policy/` |
There was a problem hiding this comment.
This appears to be the same as 7.10.2? Both contain statements 1,2,6,7,8,10.
If the desire is to delete one, perhaps change this to contain only statements 1,6,7,8,10. ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test verify that using gNMI setReqyest(Replace) we can insert statement in the middle of pre-existing policy, then remove any statement form policy, the re add this statement.
Even if statement is not first and not last one.
This test verify correctness of gNMI setReques REPLACE operation for routing policy.