Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace #18

Merged
merged 4 commits into from
Mar 20, 2024
Merged

Namespace #18

merged 4 commits into from
Mar 20, 2024

Conversation

AurelienBesnier
Copy link

Fixing namespaces

@pradal pradal self-requested a review January 23, 2024 16:32
pradal
pradal requested changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@pradal pradal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is needed in the setup.
Also, some changes are also present in another PR #19
Separate each PR in a different branch to not induce conflicts.

setup.py Outdated
# ==============================================================================

pkg_root_dir = 'src'
packages = find_packages(pkg_root_dir)
packages = find_namespace_packages(where='src', include=['openalea', 'openalea.*'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace

find_namespace_packages(where='src', include=['openalea', 'openalea.*'])

by

find_namespace_packages(where='src', include=['openalea.*'])

This is my fault.

@pradal pradal merged commit e251c8d into openalea:master Mar 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradal pradal pradal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AurelienBesnier @pradal