-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor parameterisation #28
base: master
Are you sure you want to change the base?
Refactor parameterisation #28
Conversation
improve user settings of experimental conditions
fix undefined geno bugs
@christian34 Nice job guy. For me it is much more simpler and easier to read. |
expand list of aliases to default parameters (Darwinkel, Apache, ...)
Do not understand what is the status. Can you clarify? |
The status is 'ready to merge'. |
It would be good to merge the branch before the student began to work on the refactoring. |
I agree : Bilâl should work on a version of the model that include this PR. |
OK. As soon as you have a working version, I recommend to make a tag that will fix the version. With bilal, we can work on a branch named develop. |
Okay for converging on a debugged/stabilised master. Lets just remember that all changes accepted in walter.lpy will have to be manually reported to this branch (like I just did). It may be good to synchronise master and develop from time to time to avoid this. My idea would be to merge this PR in master too once bilal has implemented his first global non-regression test (ie check that all outputs are the same as in master). |
@pradal @chrlecarpentier @Emblanc Here is my proposal for clarifying parameterisation / initialisation #26
I split parameters in modules: parameter.py (default pars), genotypic_parameters.py and experimental conditions.py.
The initialisation of parameters is done in parameter.py as a dict and imported as global variables in lpy
I also isolate the crop_conception function in a new module
The interface for parameter setting in csv is the same as before (same parameter names, including genotype dependant parameters) except or one of them : location now refer to the location / latitude only and I add meteo to refers to the climatic data. Experimental_condition.py handle that properly.