Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #21 issue #34

Closed
wants to merge 0 commits into from
Closed

Fix #21 issue #34

wants to merge 0 commits into from

Conversation

gyr
Copy link
Member

@gyr gyr commented Feb 9, 2023

It needs to return the list of requests not reviews

Fixes #21

@SchoolGuy
Copy link
Contributor

@gyr Have a look at https://github.com/openSUSE/sle-prjmgr-tools/actions/runs/4136962369/jobs/7151523128#step:3:33

Black appears to be not happy with the change.

Pylint too but that could be due to the osc 1.x changes and might be not related to your change. (Still would be good to fix it.)

@gyr
Copy link
Member Author

gyr commented Feb 10, 2023

@SchoolGuy , I've fixed black format issues.

WRT pylint ones, checking the definition of E1123, all the parameters on pylint report are valid for get_request_collection in osc/core.py. So, do you have any idea why it failed?

@SchoolGuy
Copy link
Contributor

@gyr

  • So just a hint for next time: Don't use your main branch to work on anything. Merging get's hard as soon as anything is pushed to the origin main branch.
  • Black is still unhappy
  • pylint is unhappy because the arguments are not there in osc with version 0.182. Source for 0.182 can be seen here. Version of osc that is installed can be seen here. If you want to specify the version of osc that is used then we need to set it in setup.cfg in the install_requires. That however will be tricky as RPM packaging might work but break at runtime due to the osc version taken from the OS, instead of pip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

list-accepted-pkgs is returning all packages not only the accepted ones
2 participants