Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Running the model in float16 takes up less memory, less disk space and runs faster. So, I added an option to publish the model and run inference as float16.
Modification
Added new information within the model to indicate, whether it was saved as float16, to load as well.
When loading the model, check if it is in CUDA and was saved as float16, if positive, load as float16, otherwise load normally.
Also fixed a bug when running pre-commit -> Argument 1 to "join" has incompatible type "Optional[str]"; expected "Union[str, _PathLike[str]]"
BC-breaking (Optional)
Use cases (Optional)
This PR was created and tested using pose estimators (MMPose) and a PR was created there too: open-mmlab/mmpose#3130
PS: The code works even if one of the libraries (MMPose or MMEngine) is not updated with the new suggested changes.
Checklist