Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deepcopy call to allow ONNX export #1473

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

prathikr
Copy link

@prathikr prathikr commented Jan 16, 2024

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers. By the way, if you're not familiar with how to use pre-commit to fix lint issues or add unit tests, please refer to Contributing to OpenMMLab.

Motivation

This PR is the first in an effort to integrate ONNX Runtime with MMDetection library for object detection and instance segmentation tasks.

Modification

The copy.deepcopy() operation cannot be traced by ONNX exporter. This PR removes the copy.deepcopy() call in the setter function for image metadata.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

ONNX Runtime integration with MMDetection library

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDetection or MMPretrain.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Prathik Rao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@prathikr prathikr changed the title replace deepcopy with dict copy remove deepcopy to allow ONNX tracer to export model Jan 23, 2024
@prathikr prathikr changed the title remove deepcopy to allow ONNX tracer to export model replace deepcopy with torch dict copy Jan 23, 2024
@prathikr prathikr changed the title replace deepcopy with torch dict copy remove deepcopy call to allow ONNX export Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants