-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update on gsg #245
Update on gsg #245
Conversation
Signed-off-by: aice-support <[email protected]>
Signed-off-by: aice-support <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor change, looks good otherwise
Signed-off-by: aice-support <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* updated based on comments Signed-off-by: aice-support <[email protected]> * removed curl instruction Signed-off-by: aice-support <[email protected]> * incorporated feedback Signed-off-by: aice-support <[email protected]> --------- Signed-off-by: aice-support <[email protected]> Co-authored-by: aice-support <[email protected]> Signed-off-by: alexsin368 <[email protected]>
updated gsg based on the comments.