Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update on gsg #245

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Update on gsg #245

merged 3 commits into from
Nov 7, 2024

Conversation

srinarayan-srikanthan
Copy link
Contributor

updated gsg based on the comments.

Copy link
Contributor

@arun-gupta arun-gupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor change, looks good otherwise

getting-started/README.md Outdated Show resolved Hide resolved
Signed-off-by: aice-support <[email protected]>
Copy link
Collaborator

@tomlenth tomlenth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Copy link
Collaborator

@mkbhanda mkbhanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mkbhanda mkbhanda merged commit 14a07a5 into opea-project:main Nov 7, 2024
3 checks passed
alexsin368 pushed a commit to alexsin368/opea-project-docs that referenced this pull request Nov 14, 2024
* updated based on comments

Signed-off-by: aice-support <[email protected]>

* removed curl instruction

Signed-off-by: aice-support <[email protected]>

* incorporated feedback

Signed-off-by: aice-support <[email protected]>

---------

Signed-off-by: aice-support <[email protected]>
Co-authored-by: aice-support <[email protected]>
Signed-off-by: alexsin368 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants