Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Azure instructions #237

Merged
merged 9 commits into from
Nov 4, 2024

Conversation

srinarayan-srikanthan
Copy link
Contributor

Added a tab for Azure and condensed two tabs to one.

Signed-off-by: aice-support <[email protected]>
Signed-off-by: aice-support <[email protected]>
@mkbhanda
Copy link
Collaborator

mkbhanda commented Nov 1, 2024

@srinarayan-srikanthan is there a way to include some ignores in the hyperlink tests? In particular for links that have an access token that we naturally cannot include to pass the failed test?

@srinarayan-srikanthan
Copy link
Contributor Author

@mkbhanda , yes looking into the fix for that.

@mkbhanda
Copy link
Collaborator

mkbhanda commented Nov 1, 2024

Further, that Azure home page is very generic .. taking the user through a lot of questions .. unless of course that is the only way. May be add "select 'skip'"

Copy link
Collaborator

@mkbhanda mkbhanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us be consistent, either use bold or double quotes of single quotes for commands/buttons/selection options. We currently have a mix.

getting-started/README.md Outdated Show resolved Hide resolved
getting-started/README.md Outdated Show resolved Hide resolved
getting-started/README.md Outdated Show resolved Hide resolved
getting-started/README.md Outdated Show resolved Hide resolved
getting-started/README.md Show resolved Hide resolved
getting-started/README.md Outdated Show resolved Hide resolved
getting-started/README.md Outdated Show resolved Hide resolved
Signed-off-by: aice-support <[email protected]>
Signed-off-by: aice-support <[email protected]>
@chensuyue
Copy link
Collaborator

We will handle this issue in CI.

Signed-off-by: aice-support <[email protected]>
Signed-off-by: aice-support <[email protected]>
Copy link
Contributor Author

@srinarayan-srikanthan srinarayan-srikanthan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done with all changes @mkbhanda

Copy link
Collaborator

@mkbhanda mkbhanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minor edits suggested.

getting-started/README.md Outdated Show resolved Hide resolved
getting-started/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@mkbhanda mkbhanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkbhanda mkbhanda merged commit eeb9c85 into opea-project:main Nov 4, 2024
3 checks passed
alexsin368 pushed a commit to alexsin368/opea-project-docs that referenced this pull request Nov 14, 2024
* added oci

Signed-off-by: aice-support <[email protected]>

* modified links

Signed-off-by: aice-support <[email protected]>

* added rag doc and png

Signed-off-by: aice-support <[email protected]>

* fix broken link

Signed-off-by: aice-support <[email protected]>

* standardization of code blocks

Signed-off-by: aice-support <[email protected]>

* fix typo

Signed-off-by: aice-support <[email protected]>

* rolling one commit back

Signed-off-by: aice-support <[email protected]>

* resolved suggestions from malini

Signed-off-by: aice-support <[email protected]>

---------

Signed-off-by: aice-support <[email protected]>
Co-authored-by: aice-support <[email protected]>
Co-authored-by: chen, suyue <[email protected]>
Signed-off-by: alexsin368 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants