Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sisyphus smiling/add condensed match creation txn #47

Merged

Conversation

sisyphusSmiling
Copy link
Collaborator

@sisyphusSmiling sisyphusSmiling commented Aug 4, 2023

Description

Fixes a bug found by @btspoony in the onflow/hybrid-custody repo related to the dev filter & factory setup process.

Also adds a consolidated transaction to setup a singleplayer match and submit both moves for the newly created match.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@sisyphusSmiling sisyphusSmiling added bug Something isn't working enhancement New feature or request labels Aug 4, 2023
@sisyphusSmiling sisyphusSmiling self-assigned this Aug 4, 2023
@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review August 4, 2023 17:21
…ngleplayer_match_and_submit_moves.cdc

Co-authored-by: Joshua Hannan <[email protected]>
@sisyphusSmiling sisyphusSmiling merged commit f72cc8d into main Aug 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants