Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace domain string with enum for AccountStorageMap key #3677

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Replace domain string with enum for AccountStorageMap key #3677

merged 3 commits into from
Nov 13, 2024

Commits on Nov 12, 2024

  1. Replace domain string with enum for AccountStorageMap 

    This commit replaces domain string, such as "storage",
"public", "private", etc. with domain enum (integer)
as the key for AccountStorageMap.

Also, this uses CBOR to store the domain integer in shortest form.

This optimization further improves storage efficiency
of domain payloads of PR 3664.
    @fxamacker
    fxamacker committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    bc2b313 View commit details
    Browse the repository at this point in the history

  2. Rename function convertKeyToDomain 

    This commit renames function convertKeyToDomain to
convertAccountStorageMapKeyToStorageDomain.
    @fxamacker
    fxamacker committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    88c31e6 View commit details
    Browse the repository at this point in the history

  3. Add comments and warnings about StorageDomain

    @fxamacker
    fxamacker committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    f68c5eb View commit details
    Browse the repository at this point in the history