Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC: Add built-in CCF contract with encode function #3638

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Oct 22, 2024

Work towards #3637

Description

Add a new built-in contract CCF, which allows encoding an exportable value to .

The parameter of encode is a reference, so it can accept both structs and resources, and supports move-semantics of resources (i.e. does not consume the passed resource-kinded value)

For now this is a PoC showing how this could be done.

TODO


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent changed the title Add built-in CCF contract with encode function PoC: Add built-in CCF contract with encode function Oct 22, 2024
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 85f46f7
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@turbolent
Copy link
Member Author

Unfortunately there's currently a cyclic import between encoding/ccf and stdlib at the moment, which we'll need to resolve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant