-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend type bounds #3059
Open
turbolent
wants to merge
17
commits into
master
Choose a base branch
from
bastian/extended-type-bounds
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Extend type bounds #3059
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
f384c22
extend type bounds
turbolent fffddb5
Merge branch 'master' of github.com:onflow/cadence into bastian/exten…
dsainati1 e0640f5
refactor for composability
dsainati1 cc6fb76
rewrite newly added type arguments checks with generalized bounds
dsainati1 539f15f
use generalized bounds for inclusive range
dsainati1 236ba13
composition functions for type bounds
dsainati1 142bf81
pretty printing for type bounds
dsainati1 39e8158
better printing
dsainati1 047709c
golf
dsainati1 6ea0b02
nicer printing for inclusive range param
dsainati1 decdd94
encoding and decoding json/types
dsainati1 5f32e10
basic ccf implementation for subtype bounds
dsainati1 ac6cc85
Merge branch 'master' of github.com:onflow/cadence into bastian/exten…
dsainati1 2259e0c
printing for type params
dsainati1 0a62edc
add tests for partially ordered types
dsainati1 c9f25da
add supertype type bound because our types aren't a total order
dsainati1 7e8d0d5
generate
dsainati1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1945,8 +1945,18 @@ | |
return err | ||
} | ||
|
||
// TODO: perhaps generalize this? | ||
if typeParameter.TypeBound == nil { | ||
return e.encodeNullableTypeValue(nil, visited) | ||
} | ||
|
||
subTypeBound, isSubtypeBound := typeParameter.TypeBound.(cadence.SubtypeTypeBound) | ||
if !isSubtypeBound { | ||
panic(cadenceErrors.NewUnexpectedError("cannot store non-subtype bounded function type parameter %s", typeParameter.TypeBound)) | ||
} | ||
|
||
// element 1: type as type-bound. | ||
return e.encodeNullableTypeValue(typeParameter.TypeBound, visited) | ||
return e.encodeNullableTypeValue(subTypeBound.Type, visited) | ||
Comment on lines
+1948
to
+1959
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be sufficient to support encoding any function types that aren't one of the small set of builtins that this PR changes. |
||
} | ||
|
||
// encodeParameterTypeValues encodes composite initializer parameter types as | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be sufficient to support decoding any function types that aren't one of the small set of builtins that this PR changes.