Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change urSuggestMaxCooperativeGroupCountExp to accept ND size parameter #2316

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Change urSuggestMaxCooperativeGroupCountExp to accept ND size parameter #2316

wants to merge 4 commits into from
+105 −41

Conversation

0x12CC
Copy link
Contributor

@0x12CC 0x12CC commented Nov 12, 2024

The L0 API requires calling zeKernelSetGroupSize before zeKernelSuggestMaxCooperativeGroupCount to ensure that the query result is correct. This PR changes urSuggestMaxCooperativeGroupCountExp to accept a group size with uint32_t *pworkDim and const size_t **ppLocalWorkSize parameters.

@0x12CC 0x12CC requested review from a team as code owners November 12, 2024 15:37
@github-actions github-actions bot added loader Loader related feature/bug specification Changes or additions to the specification experimental Experimental feature additions/changes/specification level-zero L0 adapter specific issues cuda CUDA adapter specific issues hip HIP adapter specific issues labels Nov 12, 2024
@0x12CC 0x12CC mentioned this pull request Nov 12, 2024
Draft
steffenlarsen
steffenlarsen approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CUDA and HIP changes LGTM!

nrspruit
nrspruit approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@nrspruit nrspruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Level Zero LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@nrspruit nrspruit nrspruit approved these changes

Assignees
No one assigned
Labels
cuda CUDA adapter specific issues experimental Experimental feature additions/changes/specification hip HIP adapter specific issues level-zero L0 adapter specific issues loader Loader related feature/bug specification Changes or additions to the specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0x12CC @nrspruit @steffenlarsen