release cleanup

.drone.yml

@@ -351,36 +351,3 @@ steps:
         - tag
     depends_on:
       - manifest-quay-tag
-
-
-  # this builds the binaries that get uploaded to GH for a release
-  # docker binaries are build in docker itself via multi-stage Docker files
-  - name: build-all-binaries
-    image: golang:1.23
-    pull: if-not-exists
-    environment:
-      GO111MODULE: on
-      LOG_LEVEL: "info"
-    commands:
-      - make build-all-binaries
-    when:
-      event:
-        - tag
-    depends_on:
-      - start
-
-  - name: release-github-binaries
-    image: golang:1.23
-    pull: if-not-exists
-    environment:
-      GITHUB_TOKEN:
-        from_secret: github_token
-      GO111MODULE: on
-    commands:
-      - "apt-get update && apt-get install -y zip"
-      - "./release-github-binaries.sh"
-    when:
-      event:
-        - tag
-    depends_on:
-      - build-all-binaries

.github/workflows/release.yml

@@ -22,6 +22,7 @@ jobs:
         run: |
           make build-all-binaries
           ls -la 
+          ls -la .build/
           ./package-github-binaries.sh
           ls -la dist/
 
@@ -30,3 +31,4 @@ jobs:
         with:
           artifacts: "dist/*"
           allowUpdates: true
+          omitBodyDuringUpdate: true

Makefile

@@ -70,7 +70,7 @@ mixin:
 
 
 BUILD_DT:=$(shell date +%F-%T)
-GO_LDFLAGS:="-s -w -extldflags \"-static\" -X main.BuildVersion=${DRONE_TAG} -X main.BuildCommitSha=${DRONE_COMMIT_SHA} -X main.BuildDate=$(BUILD_DT)" 
+GO_LDFLAGS:="-s -w -extldflags \"-static\" -X main.BuildVersion=${GITHUB_REF_NAME} -X main.BuildCommitSha=${GITHUB_SHA} -X main.BuildDate=$(BUILD_DT)"
 
 
 .PHONE: build-some-amd64-binaries
@@ -80,7 +80,7 @@ build-some-amd64-binaries:
 	rm -rf .build | true
 
 	export CGO_ENABLED=0 ; \
-	gox -os="linux windows" -arch="amd64" -verbose -rebuild -ldflags $(GO_LDFLAGS) -output ".build/redis_exporter-${DRONE_TAG}.{{.OS}}-{{.Arch}}/{{.Dir}}" && echo "done"
+	gox -os="linux windows" -arch="amd64" -verbose -rebuild -ldflags $(GO_LDFLAGS) -output ".build/redis_exporter-${GITHUB_REF_NAME}.{{.OS}}-{{.Arch}}/{{.Dir}}" && echo "done"
 
 
 .PHONE: build-all-binaries
@@ -90,9 +90,9 @@ build-all-binaries:
 	rm -rf .build | true
 
 	export CGO_ENABLED=0 ; \
-	gox -os="linux windows freebsd netbsd openbsd"        -arch="amd64 386" -verbose -rebuild -ldflags $(GO_LDFLAGS) -output ".build/redis_exporter-${DRONE_TAG}.{{.OS}}-{{.Arch}}/{{.Dir}}" && \
-	gox -os="darwin solaris illumos"                      -arch="amd64"     -verbose -rebuild -ldflags $(GO_LDFLAGS) -output ".build/redis_exporter-${DRONE_TAG}.{{.OS}}-{{.Arch}}/{{.Dir}}" && \
-	gox -os="darwin"                                      -arch="arm64"     -verbose -rebuild -ldflags $(GO_LDFLAGS) -output ".build/redis_exporter-${DRONE_TAG}.{{.OS}}-{{.Arch}}/{{.Dir}}" && \
-	gox -os="linux freebsd netbsd"                        -arch="arm"       -verbose -rebuild -ldflags $(GO_LDFLAGS) -output ".build/redis_exporter-${DRONE_TAG}.{{.OS}}-{{.Arch}}/{{.Dir}}" && \
-	gox -os="linux" -arch="arm64 mips64 mips64le ppc64 ppc64le s390x"       -verbose -rebuild -ldflags $(GO_LDFLAGS) -output ".build/redis_exporter-${DRONE_TAG}.{{.OS}}-{{.Arch}}/{{.Dir}}" && \
+	gox -os="linux windows freebsd netbsd openbsd"        -arch="amd64 386" -verbose -rebuild -ldflags $(GO_LDFLAGS) -output ".build/redis_exporter-${GITHUB_REF_NAME}.{{.OS}}-{{.Arch}}/{{.Dir}}" && \
+	gox -os="darwin solaris illumos"                      -arch="amd64"     -verbose -rebuild -ldflags $(GO_LDFLAGS) -output ".build/redis_exporter-${GITHUB_REF_NAME}.{{.OS}}-{{.Arch}}/{{.Dir}}" && \
+	gox -os="darwin"                                      -arch="arm64"     -verbose -rebuild -ldflags $(GO_LDFLAGS) -output ".build/redis_exporter-${GITHUB_REF_NAME}.{{.OS}}-{{.Arch}}/{{.Dir}}" && \
+	gox -os="linux freebsd netbsd"                        -arch="arm"       -verbose -rebuild -ldflags $(GO_LDFLAGS) -output ".build/redis_exporter-${GITHUB_REF_NAME}.{{.OS}}-{{.Arch}}/{{.Dir}}" && \
+	gox -os="linux" -arch="arm64 mips64 mips64le ppc64 ppc64le s390x"       -verbose -rebuild -ldflags $(GO_LDFLAGS) -output ".build/redis_exporter-${GITHUB_REF_NAME}.{{.OS}}-{{.Arch}}/{{.Dir}}" && \
 	echo "done"