Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade contract code to Fork12 (Banana) #10

Draft
wants to merge 10 commits into
base: dev
Choose a base branch
from

Conversation

Vui-Chee
Copy link

@Vui-Chee Vui-Chee commented Nov 15, 2024

Use Go generated code from cdk-contracts-tooling for fork12 (banana). Due to similarities between Fork12 and Fork13 (1 parameter name change), and the fact that the cdk-contracts-tooling does not have yet the generated code for Fork13, we will use Fork12 contract code instead.

Since the Polygon team already created a separate package to manage these generated code, we can reuse instead of copying over like we did last time.

There are things to take note in the newer contract function sequenceBatchesValidium,

  1. parameter name for indexL1InfoRoot is different (important since we are using Fork12 but asset management team uses Fork13)
  2. changes to parameters to the function (new params expectedFinalAccInputHash and l1InfoTreeLeafCount)

The consequences of those changes mean new params must be supplied to the signing request in order to conform to assets management team API.

repo: 0xPolygon/cdk-contracts-tooling (fork12, banana)
More renames

More madness

...

...
@Vui-Chee Vui-Chee force-pushed the vui-chee/base-dev-contract-upgrade branch from 65102e4 to 03b0845 Compare November 15, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant