fix: initialVisibleSections

okta · Nov 20, 2024 · 503f6d7 · 503f6d7
1 parent 159bfc0
commit 503f6d7
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/packages/odyssey-react-mui/src/labs/UiShell/UiShellContent.tsx b/packages/odyssey-react-mui/src/labs/UiShell/UiShellContent.tsx
@@ -141,6 +141,15 @@ const UiShellContent = ({
       </StyledBannersContainer>
 
       <StyledAppSwitcherContainer>
+        {
+          /* If AppSwitcher should be initially visible and we have not yet received props, render AppSwitcher in the loading state */
+          initialVisibleSections?.includes("AppSwitcher") &&
+            !appSwitcherProps && (
+              <ErrorBoundary fallback={null} onError={onError}>
+                <AppSwitcher isLoading appIcons={[]} selectedAppName="" />
+              </ErrorBoundary>
+            )
+        }
         {appSwitcherProps && (
           <ErrorBoundary fallback={null} onError={onError}>
             <AppSwitcher {...appSwitcherProps} />

diff --git a/packages/odyssey-storybook/src/components/odyssey-labs/UiShell/UiShell.stories.tsx b/packages/odyssey-storybook/src/components/odyssey-labs/UiShell/UiShell.stories.tsx
@@ -242,7 +242,7 @@ export const InvisibleFirstRender: StoryObj<UiShellProps> = {
 
 export const TopNavOnly: StoryObj<UiShellProps> = {
   args: {
-    initialVisibleSections: ["TopNav", "AppSwitcher"],
+    initialVisibleSections: ["TopNav"],
     optionalComponents: sharedOptionalComponents,
     subscribeToPropChanges: (subscriber) => {
       subscriber({
@@ -256,6 +256,7 @@ export const TopNavOnly: StoryObj<UiShellProps> = {
 
 export const AppSwitcherOnly: StoryObj<UiShellProps> = {
   args: {
+    initialVisibleSections: ["AppSwitcher"],
     subscribeToPropChanges: (subscriber) => {
       subscriber({
         topNavProps: {},