Skip to content
This repository has been archived by the owner on Apr 23, 2021. It is now read-only.

Projects reverse sorting #754

Merged
merged 3 commits into from
Dec 3, 2017
Merged

Projects reverse sorting #754

merged 3 commits into from
Dec 3, 2017

Conversation

johnjohndoe
Copy link
Contributor

@johnjohndoe johnjohndoe commented Sep 18, 2017 •
edited
Loading

  • Visitors should see new projects on the top of the page instead of the bottom.
  • Applied to "Projekte", "Alle Projekte" and city scoped project pages.

Review needed! 👀

  • Please check if the individual project pages render the projects in reverse chronological order.
  • Please check if the "Projekte" page, "Alle Projekte" pages render the projects in reverse chronological order.
  • Please check that the specific sorting setting for Köln still renders as configured.

Related issues / pull requests

feat. @k-nut

@johnjohndoe
Copy link
Contributor Author

I rebased the branch onto latest commit on gh-pages. Please feel free to do so before reviewing/merging.

@johnjohndoe
Copy link
Contributor Author

🦊 Does anyone feel like reviewing or commenting this?

gitviola
gitviola approved these changes Dec 3, 2017
View reviewed changes
Copy link

@gitviola gitviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@k-nut k-nut merged commit fbdc2ff into okfde:gh-pages Dec 3, 2017
@johnjohndoe
Copy link
Contributor Author

Thank you!

@johnjohndoe johnjohndoe deleted the projects-reverse-sorting branch December 3, 2017 21:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gitviola gitviola gitviola approved these changes

@michael-k michael-k Awaiting requested review from michael-k

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnjohndoe @gitviola @k-nut