Support parsing IPv6 output in OpenSSHJunOSPing Plugin #398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pinging by DNS name on Junos, the ping may use IPv4 or IPv6 and the output is different between the two
IPv4 output
IPv6 output
This patch changes the regular expression used to parse out the "time" value.
TBH, the expression could be simplified to
/^.* time=(\d+\.\d+) ms$/ and push @times,$1;
, but I didn't want to change too much.