Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] theme_*: adapt themes with new s_company_team_spotlight snippet #903

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xlu-odoo
Copy link
Contributor

@xlu-odoo xlu-odoo commented Sep 11, 2024

*: artists, aviato, bistro, nano, notes

This commit adapts the design of s_company_team_spotlight for multiple themes, based on the new Odoo 18 snippet redesign.

task-4147920
Part-of: task-4077427

requires: odoo/odoo#179844

@robodoo
Copy link
Collaborator

robodoo commented Sep 11, 2024

Pull request status dashboard

@xlu-odoo xlu-odoo force-pushed the master-website-s_company_team_spotlight-xlu branch 2 times, most recently from 20007b8 to 951885b Compare October 10, 2024 07:37
Copy link
Contributor

@mano-odoo mano-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work 💪 😉

I think it would be worth to have another look on the themes because it changed a lot since we implemented the new themes.

Eg: Theme nano should have a o_cc5 customization (dark theme), kiddo could have some shapes, vehicle could loose the border-radius...

theme_artists/views/snippets/s_company_team_spotlight.xml Outdated Show resolved Hide resolved
theme_notes/views/snippets/s_company_team_spotlight.xml Outdated Show resolved Hide resolved
@xlu-odoo xlu-odoo force-pushed the master-website-s_company_team_spotlight-xlu branch 3 times, most recently from 900f4e4 to 596534e Compare October 23, 2024 10:00
*: artists, aviato, bistro, bookstore, kiddo, notes, orchid, vehicle,
yes

This commit adapts the design of `s_company_team_spotlight` for multiple themes,
based on the new Odoo 18 snippet redesign.

task-4147920
Part-of: task-4077427
@xlu-odoo xlu-odoo force-pushed the master-website-s_company_team_spotlight-xlu branch from 596534e to 0945395 Compare October 23, 2024 10:48
Copy link
Contributor

@mano-odoo mano-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xlu-odoo xlu-odoo marked this pull request as ready for review October 23, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants