Master snippet options owl role #3300
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-snippet-options-owl-ard, it needs to be retargeted before it can be merged. |
robinlej
force-pushed
the
master-snippet-options-owl-role
branch
from
44648c4
to
b06895f
Compare
detrouxdev
reviewed
Jun 25, 2024
There was a problem hiding this comment.
Good job on those refactoring! WeList etc are not easy widgets to handle. They seem to work fairly well! Maybe next you could convert the conditional visibility option, as this one uses WeMany2many!
I left a few comments, nothing crazy, mostly questions. Once those are handled I should be able to cherry pick most of these commits 😄
robinlej
force-pushed
the
master-snippet-options-owl-role
branch
4 times, most recently
from
59bf89c
to
a649eff
Compare
detrouxdev
force-pushed
the
master-snippet-options-owl-ard
branch
from
fb98eb8
to
50c6b00
Compare
robinlej
force-pushed
the
master-snippet-options-owl-role
branch
13 times, most recently
from
394c7fd
to
1df955e
Compare
robinlej
force-pushed
the
master-snippet-options-owl-role
branch
from
1666389
to
d6f2885
Compare
detrouxdev
force-pushed
the
master-snippet-options-owl-ard
branch
from
50c6b00
to
f2f5489
Compare
robinlej
force-pushed
the
master-snippet-options-owl-role
branch
from
2a1514f
to
cd9a55e
Compare
detrouxdev
force-pushed
the
master-snippet-options-owl-ard
branch
from
f2f5489
to
b54010f
Compare
robinlej
force-pushed
the
master-snippet-options-owl-role
branch
2 times, most recently
from
20f0e05
to
eaa85d0
Compare
detrouxdev
force-pushed
the
master-snippet-options-owl-ard
branch
2 times, most recently
from
879bffb
to
51f6d38
Compare
robinlej
force-pushed
the
master-snippet-options-owl-role
branch
from
134a190
to
a5741f2
Compare
…s to Owl Kept in a separate commit as this fix only makes sense if the changes that are in the parent commit are accepted
detrouxdev
force-pushed
the
master-snippet-options-owl-ard
branch
from
2f8aa1e
to
1ea9cc1
Compare
*: website, website_sale This commit converts ImageTools and WebsiteAnimate options to OWL. For website, a new WebsiteAnimateMixin is created to be able to combine both sets of options into a single ImageToolsAnimate class in order to apply hover effects on images: the previous code moved elements from one widget to the other (back and forth) depending on some conditions, which is neither sustainable nor advisable with the OWL framework. As much as possible, the code from both ImageTools and WebsiteAnimate related to hover effects is moved into ImageToolsAnimate. Having all the methods in the same class also makes for a better and easier communication between the different widgets. For the same reason (avoid moving elements from one component to another), the commit also adds a way for options to appear directly in the Toolbar, to apply a TextAnimate class. task-3850413
This commit converts TextHighlight options to OWL. In the process, we add `<WeTextHighlightSelect>` and `<WeTextHighlightBtn>` components in order to be able to add the highlight SVGs on the `<WeButton>` once the components are mounted and have a size (i.e. once the select toggler has been opened). task-3850413
task-3850413
This commit adds a util `updateOption()` function to modify a snippet option already registered on the registry. task-3850413
robinlej
force-pushed
the
master-snippet-options-owl-role
branch
from
e97adae
to
d062586
Compare
task-3850413
robinlej
force-pushed
the
master-snippet-options-owl-role
branch
from
d062586
to
d8a5dc4
Compare
detrouxdev
force-pushed
the
master-snippet-options-owl-ard
branch
9 times, most recently
from
633ee8d
to
1240c73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.