[IMP] survey: improve preview image style #2713
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:master-survey-share-results-adsc, it needs to be retargeted before it can be merged. |
anso-odoo
force-pushed
the
master-survey-share-results-anso
branch
11 times, most recently
from
56c75d7
to
e640239
Compare
|
@schoffeniels & @Francois-frgi don't forget to check this please 👍 |
There was a problem hiding this comment.
Hello!
Nice job, I love the new designs and the code looks good overall.
I left a few propositions to improve it a little bit (comments between parenthesis are the warnings I get from the linter), but if you prefer you can keep things as is and once your part is done I'll merge it into my branch and do the changes myself, as someone else from my team will probably review the code as well afterwards 🙂
I also added a comment concerning the mask of the avatar not being transparent. I tested it and it seems to solve the issue.
Thanks !
anso-odoo
force-pushed
the
master-survey-share-results-anso
branch
2 times, most recently
from
f730d39
to
fada229
Compare
|
Thanks a lot for the review @schoffeniels |
|
This PR targets the un-managed branch odoo-dev/odoo:master-survey-share-results-adsc, it needs to be retargeted before it can be merged. |
Purpose: -------- Instead of having the survey title in the header on the start survey screen, place it in the middle of the screen, on top of the survey description. The title is a little bit higher than the middle on mobile devices. Task-2842682
Purpose: -------- Center the 'void survey' error message shown when landing on a survey that has no question. Task-2842682
Purpose: -------- The results page of a survey is now "anyone with the link"-based access. When clicking the "See Results" action on the survey, the URL of the page opened can now be shared and used by anyone, even by public users. A randomly generated "results_token" has been added to the survey model, so that the result page is still kind of hidden (the URL can not be rebuilt using other info such as the survey's name or the survey's access token). Task-2842682
Purpose: -------- When sharing URLs on social medias, a link preview is usually shown. When sharing a survey (or a survey's results), this preview now shows info related to the survey (survey's title, description, and website), as well as an image generated on the fly using the survey's information (title, user and date, background image, some statistics, and "powered by odoo" logo). The preview is not shown for surveys requiring users to log in, in order to not disclose info about the survey. Task-2842682
schoffeniels
force-pushed
the
master-survey-share-results-adsc
branch
from
eac5261
to
7a9bcb1
Compare
This commit improves the style of the image generated to be displayed when sharing the URL of the survey in social medias task-3290816
anso-odoo
force-pushed
the
master-survey-share-results-anso
branch
from
fada229
to
c555c22
Compare
schoffeniels
force-pushed
the
master-survey-share-results-adsc
branch
4 times, most recently
from
8ecddcb
to
d65891c
Compare
schoffeniels
force-pushed
the
master-survey-share-results-adsc
branch
2 times, most recently
from
0ae04cb
to
555a325
Compare
schoffeniels
force-pushed
the
master-survey-share-results-adsc
branch
8 times, most recently
from
7efa95c
to
577042a
Compare
This PR improves the style of the image generated to be displayed when sharing the URL of the survey in social medias
Before :
After (without image):
After (with image):
task-3290816