Use env var "BINANCE_API_URL" instead of harcoded url (#718)

* Use api.binance * Update url * Fix * Assign env var
oceanprotocol · Oct 5, 2023 · efe1892 · efe1892
1 parent 23549f0
commit efe1892
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/.github/workflows/flow.yml b/.github/workflows/flow.yml
@@ -22,6 +22,7 @@ jobs:
 
   dispense-active:
     env:
+      BINANCE_API_URL: ${{secrets.BINANCE_API_URL}}
       GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
     permissions:
       contents: "read"

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -9,6 +9,7 @@ on:
 
 env:
   GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
+  BINANCE_API_URL: ${{secrets.BINANCE_API_URL}}
 
 jobs:
   build:

diff --git a/df_py/util/get_rate.py b/df_py/util/get_rate.py
@@ -73,7 +73,8 @@ def get_binance_rate_all(
     @return
       rate -- float or None -- target_currency_per_token. None if failure
     """
-    url = "https://data.binance.com/api/v3/klines"
+    url_base = os.getenv("BINANCE_API_URL", "https://api.binance.com")
+    url = url_base + "/api/v3/klines"
     st_dt = datetime.fromtimestamp(timestr_to_timestamp(st))
     fin_dt = datetime.fromtimestamp(timestr_to_timestamp(fin))
     if st_dt > fin_dt: