Implicitly ended tags. #1239
Merged
Implicitly ended tags. #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panglesd
added a commit
to panglesd/odoc
that referenced
this pull request
Nov 8, 2024
|
s/implicitely/implicitly/g |
They are not necessarily at the end anymore, and the end similarly as light syntax list: on new lines or heading. This is a breaking change, which according to ocaml#1138 is fixing more things than breaking them. It will allow using custom tags and tags in mld files.
Julow
reviewed
Nov 12, 2024
|
I'm not seeing the same behavior! See eg. |
panglesd
force-pushed
the
scoped-tags
branch
from
b774c39
to
d7beb42
Compare
|
I'm also not seeing the behaviour that @Julow observed. I'd like to have a documentation page that describes these behaviours - including those of lists that I don't believe are documented anywhere. We need that before release, but not before we merge this PR :-) |
Julow
approved these changes
Nov 13, 2024
jonludlam
pushed a commit
that referenced
this pull request
Nov 13, 2024
|
Thanks! |
jonludlam
pushed a commit
to panglesd/odoc
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to solve #1138.
The solution I went for is to end tags implicitly, in the same way as shorthand list syntax is implicitly ended: by a new line, a header or a tag. Indeed, otherwise the implicit ending of a tag containing a shorthand list item is very unclear, see #1138 (comment).