Driver: uniformize names for directories #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`odoc_dir` was sometimes used to refer to the root of the directory containing .odoc files (`_odoc` by default), and sometimes used to refer to the direct parent of a `.odoc` file. The root of the directory containing `.odoc` files was referred as `odoc_dir`, `output_dir`. The root of the directory containing `.odocl` files was referred as `odocl_dir`, `link_dir`, `linked_dir`. This commit cleans that. The root of the directory for `.odoc` files is consistently named `odoc_dir`, the root for `.odocl` files is `odocl_dir`.
|
Much nicer, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
odoc_dirwas sometimes used to refer to the root of the directory containing .odoc files (_odocby default), and sometimes used to refer to the direct parent of a.odocfile.The root of the directory containing
.odocfiles was referred asodoc_dir,output_dir.The root of the directory containing
.odoclfiles was referred asodocl_dir,link_dir,linked_dir.This commit cleans that. The root of the directory for
.odocfiles is consistently namedodoc_dir, the root for.odoclfiles isodocl_dir.It has the nice effect of removing code with punning working, and fixing some misunderstanding wrt to this in the
Landing_pagemodule.