Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correcting slice_image() #931

Merged
merged 16 commits into from
Nov 6, 2023
Merged

Correcting slice_image() #931

merged 16 commits into from
Nov 6, 2023

Conversation

S-aiueo32
Copy link
Contributor

@S-aiueo32 S-aiueo32 commented Aug 13, 2023 •
edited
Loading

Similar to #930, this PR corrects slice_image() .

The changes are summarized as follow:

  • slice_image()
    • correcting the type hints.
    • removing unused t0.
    • stopping to use try-except for accessing to PIL.Image.Image.filename
      • generally speaking, try-except is computationally inefficient.
    • preventing unbound errors in appending sliced annotations by merging the processes.
  • process_coco_annotations()
    • returning List[CocoAnnotation].
  • SliceImageResult
    • fixing the type hints .

@S-aiueo32 S-aiueo32 mentioned this pull request Aug 13, 2023
Merged
@fcakyon fcakyon added this pull request to the merge queue Nov 6, 2023
Merged via the queue into obss:main with commit 739b3dd Nov 6, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcakyon fcakyon fcakyon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@S-aiueo32 @fcakyon