-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ONNX runtime support #922
ONNX runtime support #922
Conversation
Thanks for continuing this work! I thinks its very important and i am looking forward to test this if you think its ready. |
@julled You can go ahead and test it |
@karl-joan I tested your contribution. It's appear error like image below. And image which I used to test (https://ultralytics.com/images/bus.jpg) |
@LongLe18 The test is meant to be run with image specified in the test file. If you change the image, then it won't work since the image you provided does not contain any cars. If you just want to try the model, then use one of the built in functions such as |
@karl-joan ok tks sir. I understood, you have not handled except yet. I will try again |
Thanks a lot for this amazing contribution @karl-joan ! If you could add a demo notebook as other model implementations, we would gladly merge the PR 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code styling errors need to be fixed, a demo notebook need to be added
e78f5fe
to
f2b1019
Compare
@karl-joan can you please fix the styling? https://github.com/obss/sahi#contributing |
@fcakyon Yes, I'll try to get that and the notebook tomorrow done. |
@fcakyon Let me know if you need anything else. |
ONNX models compatibility to speed up CPU inference in object detections
Co-authored-by: fatih <[email protected]>
Co-authored-by: fatih <[email protected]>
Co-authored-by: fatih <[email protected]>
Co-authored-by: fatih <[email protected]>
Co-authored-by: fatih <[email protected]>
Co-authored-by: fatih <[email protected]>
@karl-joan @fcakyon what is the status here ? I can take the lead, but I assume code formatting/linting has been addressed. As far as I reviewed the files, there are no additional requirements. |
@devrimcavusoglu It's currently waiting behind @fcakyon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for the contribution @karl-joan
Made changes to pull request #904 since the author didn't respond.
Changes:
onnxruntime
.iou_threshold
was missing and bounding boxes were sent tonon_max_supression
in wrong format.onnxruntime
.onnx.py
toonnx_model.py
to avoid confusion withonnx
library.The code was designed with the intention of being used for YOLOv8 ONNX model. Perhaps some changes should be made to make it more suitable for other architectures.