-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
38/link command should not execute npm install if it was done before #103
38/link command should not execute npm install if it was done before #103
Conversation
@HaidarJbeily7 thanks for your contribution, but it would be nice to add a test that confirms that your changes work and don't break anything |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HaidarJbeily7 looks good to me, just one simple comment from my side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HaidarJbeily7 LGTM!
@rultor merge |
@maxonfjvipon OK, I'll try to merge now. You can check the progress of the merge here. |
@maxonfjvipon Done! FYI, the full log is here (took me 22min). |
@HaidarJbeily7 thanks! |
Changes
PR-Codex overview
This PR focuses on enhancing the
link
command by preventing unnecessary reinstallation of npm packages if thepackage-lock.json
file already exists. It also includes a new test case to verify this behavior.Detailed summary
package-lock.json
before runningnpm install
.package-lock.json
is not modified on subsequent runs when it exists.