feat(#3490): Attempt To Speed Up The add-refs.xsl
#3491
Merged
+86
−49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I change
add-refs.xsl
logic a bit:<xsl:key name="o-by-name" match="o[@name]" use="@name"/>
This potentially might speed up the add-refs.xsl transformation on particular files. However, initial performance measurements show rather contradictory results.
eo
shows performance degradation:and
Relate to #3490.
PR-Codex overview
This PR focuses on enhancing the
check-xsl-id.groovy
file by updating thenameFilter
to includexs3p.xsl
, while also improving the documentation inREADME.md
and adding new functionality to theadd-refs.xsl
file with new functions for node processing.Detailed summary
nameFilter
incheck-xsl-id.groovy
to includexs3p.xsl
.README.md
.xmlns:eo
andxmlns:xs
attributes to thexsl:stylesheet
inadd-refs.xsl
.eo:closest
,eo:has-intersecting-route
, andeo:get-route
for enhanced node processing.