Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move golangci-lint from pre-commit to CI #78

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

andywaltlova
Copy link
Collaborator

Trying to fix the pre-commit. I am still not convinced that our config is the issue.

@andywaltlova andywaltlova force-pushed the fix/pre-commit-golang-ci branch 2 times, most recently from b55cfcb to 25786f6 Compare August 17, 2023 09:41
@andywaltlova andywaltlova deleted the fix/pre-commit-golang-ci branch August 17, 2023 09:44
@andywaltlova andywaltlova restored the fix/pre-commit-golang-ci branch August 17, 2023 09:47
@andywaltlova andywaltlova reopened this Aug 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5152083) 67.34% compared to head (1d98101) 67.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #78   +/-   ##
=======================================
  Coverage   67.34%   67.34%           
=======================================
  Files           5        5           
  Lines         343      343           
=======================================
  Hits          231      231           
  Misses         95       95           
  Partials       17       17           
Flag Coverage Δ
go-1.16 67.34% <ø> (ø)
go-1.20 67.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andywaltlova andywaltlova changed the title Update version of golangci-lint Downgrade version of golangci-lint Aug 17, 2023
@andywaltlova
Copy link
Collaborator Author

@r0x0d I think this is somehow problem with combination of pre-commit + proxy and getting the loging pgk we use from https://git.sr.ht/~spc/go-log , the pre-commit is not used by any other project using the package (yggdrasil, rhc), locally it works fine - at least for me.

I see few options - the first is the one I would go with:

  1. don't run the pre-commit on github and just use it locally - last working version of hook with go 1.16.5 for me is v1.44.2
  2. use different logging package - possibly the one from standard library - but that seems like too much work for us when we have working implementation and only pre-commit has problem with that
  3. just ask maintainer - Link Dupont - this also seems like too much work just to get it working via pre-commit on github when it works locally

@andywaltlova andywaltlova force-pushed the fix/pre-commit-golang-ci branch 13 times, most recently from 8ca7da6 to 1d98101 Compare August 17, 2023 14:13
@andywaltlova andywaltlova changed the title Downgrade version of golangci-lint Run golangci-lint in CI and keep it as manual for local pre-commit Aug 17, 2023
Signed-off-by: Andrea Waltlova <[email protected]>
@andywaltlova andywaltlova changed the title Run golangci-lint in CI and keep it as manual for local pre-commit Move golangci-lint from pre-commit to CI Aug 17, 2023
@r0x0d r0x0d merged commit d77cb30 into oamg:main Aug 17, 2023
3 checks passed
@r0x0d r0x0d mentioned this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants