-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move golangci-lint from pre-commit to CI #78
Conversation
b55cfcb
to
25786f6
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
=======================================
Coverage 67.34% 67.34%
=======================================
Files 5 5
Lines 343 343
=======================================
Hits 231 231
Misses 95 95
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@r0x0d I think this is somehow problem with combination of pre-commit + proxy and getting the loging pgk we use from https://git.sr.ht/~spc/go-log , the pre-commit is not used by any other project using the package (yggdrasil, rhc), locally it works fine - at least for me. I see few options - the first is the one I would go with:
|
8ca7da6
to
1d98101
Compare
Signed-off-by: Andrea Waltlova <[email protected]>
Signed-off-by: Andrea Waltlova <[email protected]>
1d98101
to
073bddc
Compare
Trying to fix the pre-commit. I am still not convinced that our config is the issue.