Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary logging #66

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Conversation

r0x0d
Copy link
Member

@r0x0d r0x0d commented Aug 4, 2023

This log was placed on main during the early stages of development to figure out if the variables was being set properly, since that part is mostly stable, we can remove this log once for all.

This log was placed on main during the early stages of development to
figure out if the variables was being set properly, since that part is
mostly stable, we can remove this log once for all.

Signed-off-by: Rodolfo Olivieri <[email protected]>
@r0x0d r0x0d self-assigned this Aug 4, 2023
@r0x0d r0x0d requested a review from andywaltlova August 4, 2023 19:17
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.42% 🎉

Comparison is base (cf2eedd) 66.23% compared to head (c98eda0) 66.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   66.23%   66.66%   +0.42%     
==========================================
  Files           5        5              
  Lines         311      309       -2     
==========================================
  Hits          206      206              
+ Misses         91       89       -2     
  Partials       14       14              
Flag Coverage Δ
go-1.16 66.66% <ø> (+0.42%) ⬆️
go-1.20 66.66% <ø> (+0.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/main.go 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r0x0d r0x0d merged commit 43b0724 into oamg:main Aug 7, 2023
3 checks passed
@r0x0d r0x0d deleted the remove-unnecessary-logging branch August 7, 2023 13:44
@r0x0d r0x0d mentioned this pull request Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants