Add setup for sos report #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SOS Report needs a special file in the /etc/sos.extras.d/ folder to be able to collect the log files for the worker. Since it won't have a special plugin in sosreport due to RHEL 7 being in maintenance mode, we will be using this strategy to make sure that sosreport will be able to collect our logs. Signed-off-by: Rodolfo Olivieri <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
==========================================
- Coverage 66.23% 64.84% -1.39%
==========================================
Files 5 5
Lines 311 330 +19
==========================================
+ Hits 206 214 +8
- Misses 91 99 +8
- Partials 14 17 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
andywaltlova
requested changes
Aug 4, 2023
Signed-off-by: Rodolfo Olivieri <[email protected]>
andywaltlova
approved these changes
Aug 7, 2023
* Update parameter for setupSosExtrasReport to match what is being passed to the function. * Include a comment to specify what is the expected format for the sosreport file Signed-off-by: Rodolfo Olivieri <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SOS Report needs a special file in the /etc/sos.extras.d/ folder to be able to collect the log files for the worker. Since it won't have a special plugin in sosreport due to RHEL 7 being in maintenance mode, we will be using this strategy to make sure that sosreport will be able to collect our logs.