Update to make the yaml-file more generic #63
Conversation
The yaml-file was renamed to example.yml and the contents of it was also changed to be as generic as possible. Signed-off-by: Rodolfo Olivieri <[email protected]>
|
The idea behind this change is to make the yaml fire super generic and not tied to any specific use case. @andywaltlova I was wondering if we should provide also examples for convert2rhel and leapp alongside the example.yml file. What do you think? Let me know. |
There was a problem hiding this comment.
I think the changes make sense. We could add the examples for c2r and leapp, it would be nice to add link to README that would point to some official documentation what fields are expected by tasks in the output between markers, or just say that the stdout is dependent on the implementation on tasks side
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
==========================================
+ Coverage 66.56% 66.66% +0.10%
==========================================
Files 5 5
Lines 326 315 -11
==========================================
- Hits 217 210 -7
+ Misses 93 91 -2
+ Partials 16 14 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Rodolfo Olivieri <[email protected]>
|
@andywaltlova, updated README.md as part of the last commit. Please take a look whenever you can. |
|
Left just one question, if the sexond playbook example will be added in near future then yo ucan consider this PR approved 👍 |
Signed-off-by: Rodolfo Olivieri <[email protected]>
The yaml-file was renamed to example.yml and the contents of it was also changed to be as generic as possible.