Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite all tests with table driven approach #62

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Rewrite all tests with table driven approach #62

merged 2 commits into from
Aug 3, 2023

Conversation

andywaltlova
Copy link
Collaborator

HMS-2242

  • Split test cases to different functions

@andywaltlova andywaltlova force-pushed the fix/use-table-driven-approach-in-tests branch from 3f543c8 to 9553f9c Compare July 31, 2023 14:03
@andywaltlova andywaltlova requested a review from r0x0d July 31, 2023 14:04
@andywaltlova andywaltlova force-pushed the fix/use-table-driven-approach-in-tests branch from 9553f9c to a52e2f8 Compare July 31, 2023 14:05
r0x0d
r0x0d reviewed Jul 31, 2023
View reviewed changes
src/logger_test.go Outdated Show resolved Hide resolved
r0x0d
r0x0d reviewed Jul 31, 2023
View reviewed changes
src/runner_test.go Outdated Show resolved Hide resolved
@andywaltlova andywaltlova force-pushed the fix/use-table-driven-approach-in-tests branch from a52e2f8 to 0cbf358 Compare August 1, 2023 07:54
@andywaltlova andywaltlova self-assigned this Aug 1, 2023
r0x0d
r0x0d reviewed Aug 2, 2023
View reviewed changes
src/runner_test.go Outdated Show resolved Hide resolved
r0x0d
r0x0d reviewed Aug 2, 2023
View reviewed changes
src/util_test.go Outdated Show resolved Hide resolved
r0x0d
r0x0d reviewed Aug 2, 2023
View reviewed changes
src/util_test.go Outdated Show resolved Hide resolved
r0x0d
r0x0d reviewed Aug 2, 2023
View reviewed changes
Copy link
Member

@r0x0d r0x0d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions left, otherwise, looks pretty good!

@andywaltlova andywaltlova force-pushed the fix/use-table-driven-approach-in-tests branch from 0cbf358 to f6dc1b1 Compare August 3, 2023 06:31
r0x0d
r0x0d reviewed Aug 3, 2023
View reviewed changes
src/runner_test.go Outdated Show resolved Hide resolved
r0x0d
r0x0d reviewed Aug 3, 2023
View reviewed changes
src/server_test.go Outdated Show resolved Hide resolved
r0x0d
r0x0d reviewed Aug 3, 2023
View reviewed changes
Copy link
Member

@r0x0d r0x0d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just two comment about using the TempDir function instead of a hard coded path.

@andywaltlova
Rewrite all tests with table driven approach
3065a65 
test cases are now easily readable

Signed-off-by: Andrea Waltlova <[email protected]>
@andywaltlova
Mock insights-client call during verification tests
c9f5fb4 
Signed-off-by: Andrea Waltlova <[email protected]>
@andywaltlova andywaltlova force-pushed the fix/use-table-driven-approach-in-tests branch from f6dc1b1 to c9f5fb4 Compare August 3, 2023 12:45
@andywaltlova andywaltlova requested a review from r0x0d August 3, 2023 12:46
@andywaltlova andywaltlova merged commit cf2eedd into oamg:main Aug 3, 2023
3 checks passed
@r0x0d r0x0d mentioned this pull request Aug 10, 2023
Merged
@andywaltlova andywaltlova deleted the fix/use-table-driven-approach-in-tests branch August 17, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r0x0d r0x0d r0x0d approved these changes

Assignees

@andywaltlova andywaltlova

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andywaltlova @r0x0d