-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use separate environment for every executed command #59
Use separate environment for every executed command #59
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
==========================================
+ Coverage 66.56% 67.97% +1.41%
==========================================
Files 5 5
Lines 326 331 +5
==========================================
+ Hits 217 225 +8
+ Misses 93 92 -1
+ Partials 16 14 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
4724e9d
to
ed17941
Compare
something is not right, every other run of tests fails SOLVED: Alright, it's not deterministic to use |
ed17941
to
328eff9
Compare
src/runner.go
Outdated
log.Debugln("Insights Signature:", yamlContent.Vars.InsightsSignature) | ||
log.Debugln("Insights Signature Exclude:", yamlContent.Vars.InsightsSignatureExclude) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to remember to remove those two logs later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just removed all of the debug logs now, I never used it, can be manually added anytime during local development setup anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments, but otherwise it looks good!
Signed-off-by: Andrea Waltlova <[email protected]>
328eff9
to
04da8f2
Compare
HMS-2240