Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor server.go file and add tests #58

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Refactor server.go file and add tests #58

merged 1 commit into from
Jul 28, 2023

Conversation

andywaltlova
Copy link
Collaborator

@andywaltlova andywaltlova commented Jul 28, 2023 •
edited
Loading

Taken from #42 , just refactor with tests

@andywaltlova andywaltlova mentioned this pull request Jul 28, 2023
Closed
2 tasks
@andywaltlova andywaltlova requested a review from r0x0d July 28, 2023 10:36
r0x0d
r0x0d reviewed Jul 28, 2023
View reviewed changes
src/server.go Show resolved Hide resolved
r0x0d
r0x0d reviewed Jul 28, 2023
View reviewed changes
Copy link
Member

@r0x0d r0x0d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question about the context usage in the server.go file

@andywaltlova andywaltlova merged commit 1050628 into oamg:main Jul 28, 2023
3 checks passed
@r0x0d r0x0d mentioned this pull request Aug 10, 2023
Merged
@andywaltlova andywaltlova deleted the refactor-server branch August 17, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r0x0d r0x0d r0x0d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andywaltlova @r0x0d