Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update and improve workflows #1402

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

Venefilyn
Copy link
Member

This changes the label requirement workflows and other code styling
related workflows to better align with the current state of the repo.

This also changes the rpm generation to hopefully be better than the
current generation as the current one does not generate anything when
tags are pushed

Jira Issues:

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] or [HMS-] is part of the PR title
  • GitHub label has been added to help with Release notes
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

This changes the label requirement workflows and other code styling
related workflows to better align with the current state of the repo.

This also changes the rpm generation to hopefully be better than the
current generation as the current one does not generate anything when
tags are pushed
@Venefilyn Venefilyn added skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. tests/skip This PR does not require integration tests to be run. labels Oct 10, 2024
@has-bot
Copy link
Member

has-bot commented Oct 10, 2024

This PR does not require integration tests to be run.


Comment generated by an automation.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.58%. Comparing base (0cad386) to head (f01e8d6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1402   +/-   ##
=======================================
  Coverage   96.58%   96.58%           
=======================================
  Files          71       71           
  Lines        5090     5090           
  Branches      880      880           
=======================================
  Hits         4916     4916           
  Misses         98       98           
  Partials       76       76           
Flag Coverage Δ
centos-linux-7 92.03% <ø> (ø)
centos-linux-8 92.90% <ø> (ø)
centos-linux-9 93.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Venefilyn Venefilyn merged commit 609717d into oamg:main Oct 11, 2024
26 of 27 checks passed
@Venefilyn Venefilyn deleted the chore/update-workflows branch October 11, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. tests/skip This PR does not require integration tests to be run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants