[RHELC-1740] Use toolopts instead of env var #1387
Conversation
r0x0d
added
kind/feature
r0x0d
force-pushed
the
use-toolopts-instead-of-env-var
branch
from
4fbc573
to
be5cde1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1387 +/- ##
==========================================
+ Coverage 96.58% 96.59% +0.01%
==========================================
Files 71 71
Lines 5097 5113 +16
Branches 882 883 +1
==========================================
+ Hits 4923 4939 +16
Misses 98 98
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
r0x0d
force-pushed
the
use-toolopts-instead-of-env-var
branch
from
be5cde1
to
280d2b9
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
r0x0d
force-pushed
the
use-toolopts-instead-of-env-var
branch
3 times, most recently
from
2792a05
to
b0e4529
Compare
|
/packit test --labels sanity |
r0x0d
force-pushed
the
use-toolopts-instead-of-env-var
branch
from
b0e4529
to
6b6f809
Compare
|
/packit test --labels sanity |
r0x0d
force-pushed
the
use-toolopts-instead-of-env-var
branch
from
6b6f809
to
e8be9f5
Compare
|
/packit test --labels sanity |
r0x0d
force-pushed
the
use-toolopts-instead-of-env-var
branch
2 times, most recently
from
aa99855
to
7d1b930
Compare
|
/packit test --labels sanity |
r0x0d
force-pushed
the
use-toolopts-instead-of-env-var
branch
2 times, most recently
from
ff258d6
to
cf42f81
Compare
|
/packit test --labels sanity |
r0x0d
force-pushed
the
use-toolopts-instead-of-env-var
branch
2 times, most recently
from
ffe27cd
to
bec5606
Compare
|
/packit test --labels sanity |
|
Are failing integration tests related? https://artifacts.osci.redhat.com/testing-farm/af02265b-4d59-418a-9bf1-b24e9559802a/ |
I don't think it should be related 🤔 |
With the most recent work to migrate all environment variables to the configuration file, we need now to warn the user that the variables will be deprecated in order to use configuration file as our main place to track configuarations. This patch is introducing a very lightweight change to make sure that we will be able modify the code in the future to remove all environment variables.
Following the strategy of moving all the environment variables to be inside the configuration file, this patch introduces the ability of converting the env_var to their toolopts counterpart. This will help in the deprecation later down the road when all users are comfortable enough using the config file.
Co-authored-by: Adam Hošek <[email protected]>
r0x0d
force-pushed
the
use-toolopts-instead-of-env-var
branch
from
bec5606
to
6785977
Compare
|
/packit test --labels sanity |
That's what I suspect but it's only failing on el9 tests which passes in main branch. @danmyway WDYT |
|
Merging, saw the failing tests being the same in a different PR |
Following the strategy of moving all the environment variables to be inside the configuration file, this patch introduces the ability of converting the env_var to their toolopts counterpart. This will help in the deprecation later down the road when all users are comfortable enough using the config file.
Jira Issues:
Checklist
[RHELC-]or[HMS-]is part of the PR titleRelease Pendingif relevant