Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Improved logger usage #1373

Merged
merged 17 commits into from
Oct 24, 2024

fix: Update phase from Final to Convert

943cec0
Select commit
Loading
Failed to load commit list.
Merged

refactor: Improved logger usage #1373

fix: Update phase from Final to Convert
943cec0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 22, 2024 in 0s

96.09% (-0.51%) compared to d603f04

View this Pull Request on Codecov

96.09% (-0.51%) compared to d603f04

Details

Codecov Report

Attention: Patch coverage is 79.72973% with 30 lines in your changes missing coverage. Please review.

Project coverage is 96.09%. Comparing base (d603f04) to head (943cec0).

Files with missing lines Patch % Lines
convert2rhel/phase.py 57.69% 18 Missing and 4 partials ⚠️
convert2rhel/main.py 82.35% 2 Missing and 4 partials ⚠️
convert2rhel/logger.py 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1373      +/-   ##
==========================================
- Coverage   96.59%   96.09%   -0.51%     
==========================================
  Files          71       72       +1     
  Lines        5113     5174      +61     
  Branches      883      896      +13     
==========================================
+ Hits         4939     4972      +33     
- Misses         98      119      +21     
- Partials       76       83       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov