[RHELC-1635] State action in special pkg removal report msgs #1297
Conversation
bocekm
added
the
tests/sanity
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1297 +/- ##
=======================================
Coverage 95.83% 95.83%
=======================================
Files 55 55
Lines 4756 4756
Branches 836 836
=======================================
Hits 4558 4558
Misses 112 112
Partials 86 86
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Customers have been confused when seeing the messages, not knowing what should they do.
bocekm
force-pushed
the
state-action-in-special-pkgs-removal-msg
branch
from
c6fb81a
to
2e5ac98
Compare
|
@pr-watson, I've reworded the messages a bit. Please take a look. EDIT: I can imagine a couple of ways to improve the messages even further - I've laid the ideas out at https://issues.redhat.com/browse/RHELC-1637. They can be worked on in another PR. |
| ), | ||
| diagnosis=message, | ||
| remediations=("Check that the system runs correctly without the packages after the conversion."), |
There was a problem hiding this comment.
@bookwar, do you see a better action the user can take?
There was a problem hiding this comment.
| remediations=("Check that the system runs correctly without the packages after the conversion."), | |
| remediations="Check that the system runs correctly without the packages after the conversion.", |
| ), | ||
| remediations=( | ||
| "We do a conversion dry-run (yum transaction validation) later on as part of the pre-conversion" | ||
| " analysis. If the dry-run fails, try removing the packages listed above manually." |
There was a problem hiding this comment.
Do we want to add there also command customer can use?
There was a problem hiding this comment.
The first sentence in the remediations seems to be they would be a better fit in the diagnosis, I belive... Right now, it doesn't seem that they are fitting in the remediations correctly.
I tend to think that remediation would be a step-to-step on how to solve the problem, not really an explanation of why it failed.
Do we want to add there also command customer can use?
If we know what command can be used, I don't see why not. Would be useful
| id="SPECIAL_PACKAGES_NOT_REMOVED", | ||
| title="Special packages not removed", | ||
| description="Special packages which could not be removed", | ||
| diagnosis=message, | ||
| title="Some packages cannot be removed", |
There was a problem hiding this comment.
Maybe we should also update the id? It feels strange that in the id we call them as "special" and in the title is just "some packages"
Customers have been confused when seeing the messages, not knowing what should they do.
Jira Issues:
Checklist
[RHELC-]or[HMS-]is part of the PR titleRelease Pendingif relevant