Added basic automation functionality. #16
Draft
+13
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmbr-pip
reviewed
Dec 2, 2021
| @@ -99,6 +100,7 @@ namespace NetSoakTest | |||
| AZ_CVAR(uint16_t, soak_port, 33450, nullptr, AZ::ConsoleFunctorFlags::DontReplicate, "The port that this soak test will bind to for game traffic"); | |||
| AZ_CVAR(ProtocolType, soak_protocol, ProtocolType::Udp, nullptr, AZ::ConsoleFunctorFlags::DontReplicate, "Soak test protocol"); | |||
| AZ_CVAR(SoakMode, soak_mode, SoakMode::Loopback, nullptr, AZ::ConsoleFunctorFlags::DontReplicate, "Soak test mode"); | |||
| AZ_CVAR(SoakMode, soak_runtime, AZ::TimeMs(0), nullptr, AZ::ConsoleFunctorFlags::DontReplicate, "How long to run the soak test for before dumping stats"); | |||
There was a problem hiding this comment.
nit: Consider adding time unit, mS, S, minutes etc to description.
| @@ -38,6 +39,7 @@ namespace NetSoakTest | |||
| static void GetRequiredServices(AZ::ComponentDescriptor::DependencyArrayType& required); | |||
| static void GetDependentServices(AZ::ComponentDescriptor::DependencyArrayType& dependent); | |||
|
|
|||
| bool IsHandshakeComplete() const; | |||
There was a problem hiding this comment.
nit: consider comments for all public methods/functions
| void OnPacketLost(AzNetworking::IConnection* connection, AzNetworking::PacketId packetId) override; | ||
| void OnDisconnect(AzNetworking::IConnection* connection, AzNetworking::DisconnectReason reason, AzNetworking::TerminationEndpoint endpoint) override; | ||
| //////////////////////////////////////////////////////////////////////// | ||
|
|
||
| private: | ||
| AzNetworking::INetworkInterface* m_networkInterface = nullptr; | ||
| AzNetworking::INetworkInterface* m_loopbackInterface = nullptr; | ||
|
|
||
| AZ::TimeMs totalElapsedMs = AZ::TimeMs(0); |
Signed-off-by: scspaldi <[email protected]>
AMZN-scspaldi
force-pushed
the
scspaldi_automated_test
branch
from
0061c9d
to
a262d08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: scspaldi [email protected]
Dummy PR to run Jenkins tests, use #15 to provide feedback