Fix: spaces in path

nwjs · Oct 24, 2023 · f972394 · f972394
2 parents 966ca06 + f4ff0e2
commit f972394
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/lib/configure.js b/lib/configure.js
@@ -311,15 +311,15 @@ function configure (gyp, argv, callback) {
         !gyp.opts.nodedir ? '<(target_arch)' : '$(Configuration)',
         release.name + '.lib')
 
-      argv.push('-I', addon_gypi)
-      argv.push('-I', common_gypi)
+      argv.push('-I', '"' + addon_gypi + '"')
+      argv.push('-I', '"' + common_gypi + '"')
       argv.push('-Dlibrary=shared_library')
       argv.push('-Dvisibility=default')
-      argv.push('-Dnode_root_dir=' + nodeDir)
+      argv.push('-Dnode_root_dir="' + nodeDir + '"')
       if (process.platform === 'aix') {
         argv.push('-Dnode_exp_file=' + node_exp_file)
       }
-      argv.push('-Dnode_gyp_dir=' + nodeGypDir)
+      argv.push('-Dnode_gyp_dir="' + nodeGypDir + '"')
       argv.push('-Dnode_lib_file="' + nodeLibFile + '"')
       argv.push('-Dnw_lib_file="' + nwLibFile + '"')
       argv.push('-Dmodule_root_dir=' + process.cwd())
@@ -344,7 +344,7 @@ function configure (gyp, argv, callback) {
       argv.unshift('binding.gyp')
 
       // execute `gyp` from the current target nodedir
-      argv.unshift(gyp_script)
+      argv.unshift('"' + gyp_script + '"')
 
       // make sure python uses files that came with this particular node package
       var pypath = [path.join(__dirname, '..', 'gyp', 'pylib')]