fix: og image cards overflow #89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arashsheyda
reviewed
Oct 25, 2024
components/OgImage/OgImageNuxter.vue
Outdated
| @@ -40,7 +40,7 @@ const format = useNumberFormatter() | |||
| </svg> | |||
| <div class="font-medium text-4xl pl-2 pt-1">{{ format(contributor.score) }}</div> | |||
| </div> | |||
| <div class="flex flex-row text-gray-400 items-center pt-3 font-medium text-3xl"> | |||
| <div class="flex flex-row text-[#94a3b8] items-center pt-3 font-medium text-3xl"> | |||
There was a problem hiding this comment.
what's the reason for not using tailwind colours?
There was a problem hiding this comment.
I can't really tell why but some defined tailwind colors aren't being applied on the rendered image, for example bg-gray-900 is rendering a black background and text-gray-400 is rendering a black text even if the colors are defined in tailwind.config.ts
There was a problem hiding this comment.
Alright, ignore the previous response, I updated my branch from upstream and it seems like the tailwind colors issue has been resolved with some dependency updates before so I reverted the class changes from my PR
arashsheyda
reviewed
Oct 25, 2024
components/OgImage/OgImageNuxter.vue
Outdated
| @@ -10,7 +10,7 @@ const format = useNumberFormatter() | |||
| </script> | |||
|
|
|||
| <template> | |||
| <div class="flex flex-row justify-between w-full p-[38px] bg-gray-900"> | |||
| <div class="flex flex-row justify-between w-full p-[38px] bg-[#0f172a]"> | |||
There was a problem hiding this comment.
can you add h-full so we get rid of the white space at the bottom? thanks
Yizack
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #88
❓ Type of change
📚 Description
I'm not a Tailwind expert but it seems like the og module is not seeing the colors when using classes likebg-gray-900,text-gray-400so instead I used Arbitrary values. If someone knows how to make the color classes work the help is welcomed!And for fixing the overflowing I simply added the
overflow-hiddentailwing class to each cardThe image below is how it looks with the changes