Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Syntax Errors in Create App Security Rule Example #394

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

Nathaniel-Roberts
Copy link
Contributor

I tried to use this example in an Ansible Playbook and the syntax doesn't work, it also doesn't reflect the documentation directly above it. So made it work with correct syntax and tested with Nutanix Prism Central.

@bhati-pradeep bhati-pradeep added the 1.9.1 Bug fixes & Improvements label Sep 28, 2023
Copy link
Collaborator

@Gevorg-Khachatryan-97 Gevorg-Khachatryan-97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

@bhati-pradeep
Copy link
Collaborator

@Nathaniel-Roberts Thank you for your valuable contribution !

@bhati-pradeep bhati-pradeep added the documentation Improvements or additions to documentation label Oct 30, 2023
@bhati-pradeep bhati-pradeep changed the base branch from main to release/1.9.1 October 30, 2023 20:50
@bhati-pradeep bhati-pradeep merged commit 5069b95 into nutanix:release/1.9.1 Oct 30, 2023
premkarat pushed a commit that referenced this pull request Nov 9, 2023
* example fix (#420)

Co-authored-by: Gevorg-Khachatryaan <Gevorg1050.1>

* Add cluster URL to response only when there is cluster creation (#402)

* Create cluster url when it is required

* Minor fix

* fiql string in filtering (#423)

* fiql string in filtering

* fix

* Add Tests

* example for filter string

---------

Co-authored-by: Gevorg-Khachatryaan <Gevorg1050.1>
Co-authored-by: Alaa Bishtawi <[email protected]>

* Bug/issue#383 (#411)

* Fix Jekyll Build

* fix

* Fix #391 and #418 (#419)

* Create cluster url when it is required

* Minor fix

* Change api url for fetching time machine using name to get complete info same as uuid

* Add attribute in clone modules in ndb for creation or refresh using latestSnapshot

* Minor typo fix

* Minor typo fix

* functionality to update owner of vms (#412)

* functionality to update owner of vm

* sanity fix

* add test

---------

Co-authored-by: Gevorg-Khachatryaan <Gevorg1050.1>
Co-authored-by: Alaa Bishtawi <[email protected]>

* example for vms inventory (#410)

Co-authored-by: Gevorg-Khachatryaan <Gevorg1050.1>

* fix for custom filter and examples (#417)

* fix for custom filter and examples

* black fix

* sanity fix

* Add test

---------

Co-authored-by: Gevorg-Khachatryaan <Gevorg1050.1>
Co-authored-by: Alaa Bishtawi <[email protected]>

* example for vms inventory  (#426)

* example for vms inventory

* ansible cfg

* Move cfg to inventory example folder

* Minor name changes

* Minor fix

---------

Co-authored-by: Gevorg-Khachatryaan <Gevorg1050.1>
Co-authored-by: Pradeepsingh Bhati <[email protected]>

* Add support for PC Categories (#405)

Co-authored-by: Gianluca Salvo <[email protected]>

* Bug/issue#400 (#403)

* fix issue #400

* fix issue #400

---------

Co-authored-by: Gevorg-Khachatryaan <Gevorg1050.1>

* example for VMs with guest customization file which injects variables from the playbook (#396)

Co-authored-by: Gevorg-Khachatryaan <Gevorg1050.1>

* Fix: Syntax Errors in Create App Security Rule Ex (#394)

* functionality to handle issue when size of new disk is absent (#393)

Co-authored-by: Gevorg-Khachatryaan <Gevorg1050.1>

* example fix (#392)

Co-authored-by: Gevorg-Khachatryaan <Gevorg1050.1>

* sanity fix

* fix for issue#360 (#408)

* fix for issue#360

* fix

---------

Co-authored-by: Gevorg-Khachatryaan <Gevorg1050.1>

* improve clone examples (#407)

* imporve clone examples

* Fix Examples

* sanity fix

* disbale tests

* Enhance Acp Tests

* fix disks issue when size gb is not given for clone image disks

* Set release version 1.9.1

* enable image tests

* enable foundation sanity test

* Minor foundation test fix

* Enable pc tests

* Enable karbon and foundation sanity

* disables tests

* enables tests

* enable pc tests

* add tests for clones with latest snapshot. And enable clones and NDB database sanity tests

* skip protection rules tests

* Add random naming for acp test with user reference

* Bug/191 fix database sanity test (#430)

* Revert "Bug/issue#383 (#411)"

This reverts commit d1a0016.

* Fix Properties map

* Skip jelkyll check on database sanity test build issue

---------

Co-authored-by: Pradeepsingh Bhati <[email protected]>

* fix ntnx_database_sanity

* Add Contributaiong (#431)

* Add Contributaiong

* enhance contributaion

* fix readme

* Add comments to sample var files for simplicity

* Minor typo

---------

Co-authored-by: Pradeepsingh Bhati <[email protected]>

* Release Notes and changelog changes

* Minor typo fix

* remove unrequired file

* Minor release bug list change due to non cherry picks

---------

Co-authored-by: Gevorg Khachatryan <[email protected]>
Co-authored-by: Alaa Bishtawi <[email protected]>
Co-authored-by: Gianluca Salvo <[email protected]>
Co-authored-by: Gianluca Salvo <[email protected]>
Co-authored-by: Nathaniel Roberts <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.9.1 Bug fixes & Improvements documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants