[CORRECTION] Appel du endpoint FC+ de destruction de session si nonce retourné invalide #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… À la racine dudit cookie, pour pouvoir ensuite le réutiliser même si on n'a pas stocké les informations utilisateurs – cas du nonce invalide, où on redirige vers la destruction de session avant même d'avoir stocké les informations utilisateur.
egaillot
commented
Jul 15, 2024
egaillot
force-pushed
the
stockage-jwt-session-fcplus-dans-cookie-session
branch
from
6f9de6f
to
4c6f743
Compare
egaillot
changed the title
egaillot
force-pushed
the
stockage-jwt-session-fcplus-dans-cookie-session
branch
3 times, most recently
from
6fb975e
to
a26451c
Compare
Co-authored-by: Fabien Lamarque <[email protected]>
egaillot
force-pushed
the
stockage-jwt-session-fcplus-dans-cookie-session
branch
from
a26451c
to
863f0eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jusqu'à présent, si le nonce retourné était invalide, on redirigeait vers
GET /auth/fcplus/destructionSessionFCPlussans avoir mis les infos utilisateur (dans lequel se trouvait le JWT de session FC+) dans le cookie de session. Ces infos étant inexistantes, on redirigeait directement depuisdestructionSessionFCPlusversdeconnexion, et le endpoint FC+ n'était pas appelé.Cela nous motive à sortir l'info JWT de session FC+ hors des infos utilisateur (où on l'avait mis pour gagner du temps), et à commencer à utiliser directement les mécanismes de gestion de cookie de session de express.js (
requete.session.jwtSessionFCPlus = …) plutôt que de chiffrer à la main.