-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for compiler-rt inclusion #909
Conversation
Developer Note: This PR depends on merging LLVM14 changes. |
From OOB discussion, the OSX build failure is depending on conda/conda-build#4787 to successfully build compiler-rt |
@sklam and @gmarkall ready for review after adding support for llvm 14. Note that there are several places where I was forced to iinstall llvmdev from my channel because it includes compiler-rt. For example: "call conda install -y -q --override-channels -c mcollison llvmdev="14.*" Note that MacOS is still failing due to: conda/conda-build#4787 |
@esc, please consider this and related PR for inclusion of the upcoming llvmlite release. |
Thank you, added to the milestone. |
@testhound I followed this PR, and it seems |
@oliverhu This PR is not being worked on by @testhound anymore, and needs someone to pick it up and continue it - eventually someone working on Numba / llvmlite may get round to it, but it could take some time - do you have any interest in attempting to adopt this PR and working on it? I'm happy whether you are or aren't - just let me know if you are and we can figure out some steps to move this forward. |
@gmarkall thanks! happy to help here...the only concern is I'm new to this project (got a crash from tinygrad/tinygrad#1367 so I hunted all the way down here). I might not have the full context besides the issue I was impacted. Is there a channel (slack/discord) to discuss questions? back-n-forth in GitHub is not the most effective way! |
@oliverhu There's the Numba Gitter (https://matrix.to/#/#numba_numba:gitter.im) - I'm usually around there during UK office hours (it's 11pm here but I can discuss this interactively tomorrow). |
Sounds good, will reach out on gitter! |
This pull request adds support for including compiler-rt as a artifact. It is meant to address this outstanding issue:
#834