Refine chat response. #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mathewjordan
commented
Mar 6, 2024
mathewjordan
commented
- Implement Chat-based queries.
- Shift Chat to search screen, rename directory.
- Partially remove localstorage dependencies in chat component. Pull question data from primary Search bar
- More work
- Make straming answers work more reliably.
- Incomplete search pieces to help with generative ai search
- Wire up not logged in modal on Search page directing users to login if they want to use generative AI search
- Refine chat response.
mathewjordan
changed the base branch from
deploy/staging
to
preview/chat-integration
adamjarling
reviewed
Mar 7, 2024
There was a problem hiding this comment.
This is awesome, and can't wait to see it rebased on latest preview/chat-integration.
I know it's nit-picky, but when we're in files, if possible let's lean on the import path aliases@ so when we move stuff around it's less hassle.
import { StyledStreamedAnswer } from "./Response.styled";
// prefer this
import useMarkdown from "@/hooks/useMarkdown";
mathewjordan
force-pushed
the
4562-chat-response
branch
2 times, most recently
from
4f80da0
to
75a48e9
Compare
|
Thanks for taking a look @adamjarling. This is ready for another review. |
adamjarling
approved these changes
Mar 8, 2024
mathewjordan
force-pushed
the
4562-chat-response
branch
from
24e9a13
to
2998278
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.