Skip to content

Commit

Permalink
Merge pull request #222 from nulib/4691-match-node-versions
Browse files Browse the repository at this point in the history
Update dev, test, and deploy to NodeJS 20.x
  • Loading branch information
mbklein authored Jun 24, 2024
2 parents 7485ef4 + 9f37664 commit 8aa0395
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test-node.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 20.x
cache: "npm"
cache-dependency-path: 'node/package-lock.json'
- run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion .tool-versions
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
nodejs 16.14.0
nodejs 20.15.0
java corretto-19.0.1.10.1
aws-sam-cli 1.107.0
python 3.10.5
2 changes: 1 addition & 1 deletion chat/template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ Resources:
- logs:PutLogEvents
Resource: !Sub "${ChatMetricsLog.Arn}:*"
Metadata:
BuildMethod: nodejs18.x
BuildMethod: nodejs20.x
ChatMetricsLog:
Type: AWS::Logs::LogGroup
Properties:
Expand Down
14 changes: 7 additions & 7 deletions template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Description: >
Globals:
Function:
CodeUri: ./node/src
Runtime: nodejs18.x
Runtime: nodejs20.x
Architectures:
- x86_64
MemorySize: 128
Expand Down Expand Up @@ -127,10 +127,10 @@ Resources:
#* Description: Dependencies for API handlers
#* ContentUri: ./layers/api_dependencies
#* CompatibleRuntimes:
#* - nodejs18.x
#* - nodejs20.x
#* LicenseInfo: Apache-2.0
#* Metadata:
#* BuildMethod: nodejs18.x
#* BuildMethod: nodejs20.x
# V2 API
getAuthCallbackFunction:
Type: AWS::Serverless::Function
Expand Down Expand Up @@ -947,7 +947,7 @@ Resources:
startTranscodeFunction:
Type: AWS::Serverless::Function
Properties:
Runtime: nodejs18.x
Runtime: nodejs20.x
CodeUri: ./lambdas
Handler: start-transcode.handler
Description: Creates MediaConvert Job to transcode HLS stream
Expand All @@ -973,7 +973,7 @@ Resources:
transcodeStatusFunction:
Type: AWS::Serverless::Function
Properties:
Runtime: nodejs18.x
Runtime: nodejs20.x
CodeUri: ./lambdas
Handler: transcode-status.handler
Description: Determines when transcode job has completed or errored
Expand All @@ -992,7 +992,7 @@ Resources:
getDownloadLinkFunction:
Type: AWS::Serverless::Function
Properties:
Runtime: nodejs18.x
Runtime: nodejs20.x
CodeUri: ./lambdas
Handler: get-download-link.handler
Description: Creates presigned url
Expand All @@ -1007,7 +1007,7 @@ Resources:
sendTemplatedEmailFunction:
Type: AWS::Serverless::Function
Properties:
Runtime: nodejs18.x
Runtime: nodejs20.x
CodeUri: ./lambdas
Handler: send-templated-email.handler
Description: Sends email
Expand Down

0 comments on commit 8aa0395

Please sign in to comment.