Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add gpio configuration for nrf54l15 #540

Merged

Conversation

RobertGalatNordic
Copy link
Collaborator

@RobertGalatNordic RobertGalatNordic commented Apr 11, 2024

allows to initialize FSK/LoRa, but still does not work

CI parameters

Github_actions:
  #(branch, hash, pull/XXX/head)
  NRF_revision: main

  # Do not change after creating PR
  Create_NRF_PR: false
Jenkins:
  test-sdk-sidewalk: moonlight-v0.3.0

Description

JIRA ticket: KRKNWK-18781

Self review

  • There is no commented code.
  • There are no TODO/FIXME comments without associated issue ticket.
  • Commits are properly organized.
  • Change has been tested.
  • Tests were updated (if applicable).

@github-actions github-actions bot added the source PR changing src files label Apr 11, 2024
Copy link

github-actions bot commented Apr 11, 2024

Sample diff used total
nrf54l15pdk/nrf54l15/cpuapp:sample.sidewalk.dut RAM -121.8 KB 0 B 256 KB
ROM -414.21 KB 0 B 730 KB
nrf54l15pdk/nrf54l15/cpuapp:sample.sidewalk.hello RAM -88.16 KB 0 B 256 KB
ROM -350.43 KB 0 B 730 KB
nrf54l15pdk/nrf54l15/cpuapp:sample.sidewalk.hello.ble_only RAM -88.16 KB 0 B 256 KB
ROM -350.18 KB 0 B 730 KB
nrf54l15pdk/nrf54l15/cpuapp:sample.sidewalk.hello.ble_only.release RAM -83.34 KB 0 B 256 KB
ROM -284.93 KB 0 B 730 KB
nrf54l15pdk/nrf54l15/cpuapp:sample.sidewalk.hello.release RAM -83.34 KB 0 B 256 KB
ROM -285.07 KB 0 B 730 KB
thingy53/nrf5340/cpuapp:sample.sidewalk.demo.ble_only RAM 0 B 102.34 KB 440 KB
ROM 4 B 391.99 KB 975.5 KB
nrf52840dk/nrf52840:sample.sidewalk.demo RAM 0 B 119.89 KB 256 KB
ROM 16 B 495.48 KB 983.5 KB
nrf52840dk/nrf52840:sample.sidewalk.dut RAM 0 B 143.27 KB 256 KB
ROM 20 B 553.93 KB 983.5 KB
nrf52840dk/nrf52840:sample.sidewalk.hello RAM 0 B 109.64 KB 256 KB
ROM -76 B 495.01 KB 983.5 KB
nrf52840dk/nrf52840:sample.sidewalk.hello.ble_only RAM 0 B 94.14 KB 256 KB
ROM -112 B 412.55 KB 983.5 KB
nrf52840dk/nrf52840:sample.sidewalk.hello.ble_only.release RAM 0 B 89.39 KB 256 KB
ROM -96 B 351.52 KB 983.5 KB
nrf52840dk/nrf52840:sample.sidewalk.hello.release RAM 0 B 104.77 KB 256 KB
ROM -80 B 429.83 KB 983.5 KB
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.demo RAM 0 B 108.05 KB 440 KB
ROM 16 B 434.33 KB 975.5 KB
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.dut RAM 0 B 131.53 KB 440 KB
ROM 20 B 492.82 KB 975.5 KB
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello RAM 0 B 98.14 KB 440 KB
ROM -80 B 433.93 KB 975.5 KB
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello.ble_only RAM 0 B 82.95 KB 440 KB
ROM -112 B 355.24 KB 975.5 KB
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello.ble_only.release RAM 0 B 78.27 KB 440 KB
ROM -96 B 291.04 KB 975.5 KB
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello.release RAM 0 B 93.45 KB 440 KB
ROM -80 B 366.45 KB 975.5 KB
nrf54l15pdk/nrf54l15/cpuapp:sample.sidewalk.demo RAM -98.11 KB 0 B 256 KB
ROM -351.01 KB 0 B 730 KB
nrf54l15pdk/nrf54l15/cpuapp:sample.sidewalk.demo.ble_only RAM -98.11 KB 0 B 256 KB
ROM -350.76 KB 0 B 730 KB
[email protected]/nrf54l15/cpuapp:sample.sidewalk.dut RAM 137.23 KB 137.23 KB 256 KB
ROM 493.82 KB 493.82 KB 730 KB
[email protected]/nrf54l15/cpuapp:sample.sidewalk.hello RAM 103.54 KB 103.54 KB 256 KB
ROM 430.02 KB 430.02 KB 730 KB
[email protected]/nrf54l15/cpuapp:sample.sidewalk.hello.ble_only RAM 88.16 KB 88.16 KB 256 KB
ROM 350.02 KB 350.02 KB 730 KB
[email protected]/nrf54l15/cpuapp:sample.sidewalk.hello.ble_only.release RAM 83.34 KB 83.34 KB 256 KB
ROM 284.79 KB 284.79 KB 730 KB
[email protected]/nrf54l15/cpuapp:sample.sidewalk.hello.release RAM 98.71 KB 98.71 KB 256 KB
ROM 361.02 KB 361.02 KB 730 KB
[email protected]/nrf54l15/cpuapp:sample.sidewalk.demo RAM 113.48 KB 113.48 KB 256 KB
ROM 430.53 KB 430.53 KB 730 KB
[email protected]/nrf54l15/cpuapp:sample.sidewalk.demo.ble_only RAM 98.11 KB 98.11 KB 256 KB
ROM 350.76 KB 350.76 KB 730 KB
.config diff

.config change: https://github.com/nrfconnect/sdk-sidewalk/actions/runs/8987239006/artifacts/1480574193


./manual-tests-artifacts/twister-out/nrf52840dk_nrf52840/log/sidewalk.test.log/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./manual-tests-artifacts/twister-out/nrf52840dk_nrf52840/ble/sidewalk.test.ble/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./manual-tests-artifacts/twister-out/nrf52840dk_nrf52840/simple_bootloader/sidewalk.test.simple_bootloader/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./manual-tests-artifacts/twister-out/nrf5340dk_nrf5340_cpuapp/log/sidewalk.test.log/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./manual-tests-artifacts/twister-out/nrf5340dk_nrf5340_cpuapp/ble/sidewalk.test.ble/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./manual-tests-artifacts/twister-out/nrf5340dk_nrf5340_cpuapp/simple_bootloader/sidewalk.test.simple_bootloader/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./sample-artifacts-meta/twister-out/nrf52840dk_nrf52840/sid_end_device/sample.sidewalk.hello.release/mcuboot/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./sample-artifacts-meta/twister-out/nrf52840dk_nrf52840/sid_end_device/sample.sidewalk.hello.release/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./sample-artifacts-meta/twister-out/nrf52840dk_nrf52840/sid_end_device/sample.sidewalk.hello.ble_only.release/mcuboot/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./sample-artifacts-meta/twister-out/nrf52840dk_nrf52840/sid_end_device/sample.sidewalk.hello.ble_only.release/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./sample-artifacts-meta/twister-out/nrf52840dk_nrf52840/sid_end_device/sample.sidewalk.demo.ble_only/mcuboot/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./sample-artifacts-meta/twister-out/nrf52840dk_nrf52840/sid_end_device/sample.sidewalk.demo.ble_only/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./sample-artifacts-meta/twister-out/nrf52840dk_nrf52840/sid_end_device/sample.sidewalk.dut/mcuboot/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./sample-artifacts-meta/twister-out/nrf52840dk_nrf52840/sid_end_device/sample.sidewalk.dut/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./sample-artifacts-meta/twister-out/nrf52840dk_nrf52840/sid_end_device/sample.sidewalk.hello.ble_only/mcuboot/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./sample-artifacts-meta/twister-out/nrf52840dk_nrf52840/sid_end_device/sample.sidewalk.hello.ble_only/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./sample-artifacts-meta/twister-out/nrf52840dk_nrf52840/sid_end_device/sample.sidewalk.hello/mcuboot/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./sample-artifacts-meta/twister-out/nrf52840dk_nrf52840/sid_end_device/sample.sidewalk.hello/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./sample-artifacts-meta/twister-out/nrf52840dk_nrf52840/sid_end_device/sample.sidewalk.demo/mcuboot/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./sample-artifacts-meta/twister-out/nrf52840dk_nrf52840/sid_end_device/sample.sidewalk.demo/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./sample-artifacts-meta/twister-out/thingy53_nrf5340_cpuapp/sid_end_device/sample.sidewalk.demo.ble_only/mcuboot/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./sample-artifacts-meta/twister-out/thingy53_nrf5340_cpuapp/sid_end_device/sample.sidewalk.demo.ble_only/hci_ipc/b0n/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./sample-artifacts-meta/twister-out/thingy53_nrf5340_cpuapp/sid_end_device/sample.sidewalk.demo.ble_only/hci_ipc/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./sample-artifacts-meta/twister-out/thingy53_nrf5340_cpuapp/sid_end_device/sample.sidewalk.demo.ble_only/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./sample-artifacts-meta/twister-out/nrf5340dk_nrf5340_cpuapp/sid_end_device/sample.sidewalk.hello.release/mcuboot/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./sample-artifacts-meta/twister-out/nrf5340dk_nrf5340_cpuapp/sid_end_device/sample.sidewalk.hello.release/hci_ipc/b0n/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./sample-artifacts-meta/twister-out/nrf5340dk_nrf5340_cpuapp/sid_end_device/sample.sidewalk.hello.release/hci_ipc/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./sample-artifacts-meta/twister-out/nrf5340dk_nrf5340_cpuapp/sid_end_device/sample.sidewalk.hello.release/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./sample-artifacts-meta/twister-out/nrf5340dk_nrf5340_cpuapp/sid_end_device/sample.sidewalk.hello.ble_only.release/mcuboot/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./sample-artifacts-meta/twister-out/nrf5340dk_nrf5340_cpuapp/sid_end_device/sample.sidewalk.hello.ble_only.release/hci_ipc/b0n/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./sample-artifacts-meta/twister-out/nrf5340dk_nrf5340_cpuapp/sid_end_device/sample.sidewalk.hello.ble_only.release/hci_ipc/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./sample-artifacts-meta/twister-out/nrf5340dk_nrf5340_cpuapp/sid_end_device/sample.sidewalk.hello.ble_only.release/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./sample-artifacts-meta/twister-out/nrf5340dk_nrf5340_cpuapp/sid_end_device/sample.sidewalk.demo.ble_only/mcuboot/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./sample-artifacts-meta/twister-out/nrf5340dk_nrf5340_cpuapp/sid_end_device/sample.sidewalk.demo.ble_only/hci_ipc/b0n/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./sample-artifacts-meta/twister-out/nrf5340dk_nrf5340_cpuapp/sid_end_device/sample.sidewalk.demo.ble_only/hci_ipc/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./sample-artifacts-meta/twister-out/nrf5340dk_nrf5340_cpuapp/sid_end_device/sample.sidewalk.demo.ble_only/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./sample-artifacts-meta/twister-out/nrf5340dk_nrf5340_cpuapp/sid_end_device/sample.sidewalk.dut/mcuboot/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./sample-artifacts-meta/twister-out/nrf5340dk_nrf5340_cpuapp/sid_end_device/sample.sidewalk.dut/hci_ipc/b0n/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./sample-artifacts-meta/twister-out/nrf5340dk_nrf5340_cpuapp/sid_end_device/sample.sidewalk.dut/hci_ipc/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=y

./sample-artifacts-meta/twister-out/nrf5340dk_nrf5340_cpuapp/sid_end_device/sample.sidewalk.dut/zephyr/.config
old                                                           | new
							      >	CONFIG_SUIT_ENVELOPE_OUTPUT_ARTIFACT="merged.hex"

Configuration diff too long to fit. Check file in artifacts.

@RobertGalatNordic RobertGalatNordic force-pushed the nrf54l15_semtech branch 9 times, most recently from c8d1f68 to 95b3ce1 Compare April 17, 2024 09:09
@RobertGalatNordic RobertGalatNordic force-pushed the nrf54l15_semtech branch 2 times, most recently from 8f444fe to b6addf8 Compare April 26, 2024 07:02
@github-actions github-actions bot added the tests label Apr 26, 2024
@RobertGalatNordic RobertGalatNordic force-pushed the nrf54l15_semtech branch 3 times, most recently from 4f63c39 to 661a649 Compare May 7, 2024 13:29
allows to initialize FSK/LoRa on pdk v0.2.1

Signed-off-by: Robert Gałat <[email protected]>
KRKNWK-18781

add semtech configuration for [email protected]

Signed-off-by: Robert Gałat <[email protected]>
Copy link
Contributor

@ktaborowski ktaborowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, waiting for positive test results :)
I think we should remove the board revisions suffixes when the new revision becomes defult in zephyr

@RobertGalatNordic RobertGalatNordic merged commit 9d20dfb into nrfconnect:main May 9, 2024
56 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
func-commit source PR changing src files tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants