-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logs quick fix #536
Merged
Merged
Logs quick fix #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
totyz
requested changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still see <inf> app_tx: Capability send
or similar in Demo app in DFU mode
CONF_FILE is a list Signed-off-by: Krzysztof Taborowski <[email protected]>
[KRKNWK-18489] Signed-off-by: Krzysztof Taborowski <[email protected]>
ktaborowski
force-pushed
the
logs-quick-fix
branch
from
April 9, 2024 13:35
9cf818e
to
bca1a1c
Compare
[KRKNWK-18777] Signed-off-by: Krzysztof Taborowski <[email protected]>
[KRKNWK-18804] Signed-off-by: Krzysztof Taborowski <[email protected]>
ktaborowski
force-pushed
the
logs-quick-fix
branch
from
April 9, 2024 14:39
bca1a1c
to
b4bde2b
Compare
totyz
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decrease level of some log message - might be misleading
CI parameters
(branch, hash, pull/XXX/head)
NRF_revision=main
(true, false)
Create_NRF_PR=true
Description
JIRA ticket:
Detail description of the change
Self review