Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs quick fix #536

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Logs quick fix #536

merged 4 commits into from
Apr 11, 2024

Conversation

ktaborowski
Copy link
Contributor

@ktaborowski ktaborowski commented Apr 9, 2024

decrease level of some log message - might be misleading

CI parameters

(branch, hash, pull/XXX/head)
NRF_revision=main

(true, false)
Create_NRF_PR=true

Description

JIRA ticket:

Detail description of the change

Self review

  • There is no commented code.
  • There is no TODO/FIXME comments without associated issue ticket.
  • Commits are properly organized
  • Verification
    • Unit tests were updated to include the change.
    • Change has been tested.

@github-actions github-actions bot added the source PR changing src files label Apr 9, 2024
Copy link

github-actions bot commented Apr 9, 2024

Sample diff used total
nrf54l15pdk_nrf54l15_cpuapp:sample.sidewalk.dut RAM 0 B 121.36 KB 256 KB
ROM 40 B 414.93 KB 730 KB
nrf54l15pdk_nrf54l15_cpuapp:sample.sidewalk.hello RAM 0 B 87.74 KB 256 KB
ROM -88 B 350.85 KB 730 KB
nrf54l15pdk_nrf54l15_cpuapp:sample.sidewalk.hello.ble_only RAM 0 B 87.74 KB 256 KB
ROM -88 B 350.6 KB 730 KB
nrf54l15pdk_nrf54l15_cpuapp:sample.sidewalk.hello.no_dfu RAM 0 B 74.47 KB 256 KB
ROM -88 B 332.09 KB 1.48 MB
thingy53_nrf5340_cpuapp:sample.sidewalk.demo.ble_only RAM 0 B 102.42 KB 440 KB
ROM 8 B 390.86 KB 975.5 KB
nrf52840dk_nrf52840:sample.sidewalk.demo RAM 0 B 119.83 KB 256 KB
ROM -8 B 495.27 KB 983.5 KB
nrf52840dk_nrf52840:sample.sidewalk.demo.ble_only RAM 128 B 104.33 KB 256 KB
ROM -4 B 412.82 KB 983.5 KB
nrf52840dk_nrf52840:sample.sidewalk.dut RAM 0 B 143.21 KB 256 KB
ROM 40 B 554.23 KB 983.5 KB
nrf52840dk_nrf52840:sample.sidewalk.hello RAM 0 B 109.58 KB 256 KB
ROM -88 B 494.89 KB 983.5 KB
nrf52840dk_nrf52840:sample.sidewalk.hello.ble_only RAM 0 B 94.08 KB 256 KB
ROM -72 B 412.22 KB 983.5 KB
nrf52840dk_nrf52840:sample.sidewalk.hello.no_dfu RAM 0 B 96.29 KB 256 KB
ROM -164 B 477.01 KB 1012 KB
nrf5340dk_nrf5340_cpuapp:sample.sidewalk.demo RAM 0 B 108.09 KB 440 KB
ROM -4 B 433.1 KB 975.5 KB
nrf5340dk_nrf5340_cpuapp:sample.sidewalk.demo.ble_only RAM 0 B 92.89 KB 440 KB
ROM -8 B 354.45 KB 975.5 KB
nrf5340dk_nrf5340_cpuapp:sample.sidewalk.dut RAM 0 B 131.55 KB 440 KB
ROM 40 B 492.09 KB 975.5 KB
nrf5340dk_nrf5340_cpuapp:sample.sidewalk.hello RAM 0 B 98.18 KB 440 KB
ROM -72 B 432.81 KB 975.5 KB
nrf5340dk_nrf5340_cpuapp:sample.sidewalk.hello.ble_only RAM 0 B 82.97 KB 440 KB
ROM -84 B 354.11 KB 975.5 KB
nrf5340dk_nrf5340_cpuapp:sample.sidewalk.hello.no_dfu RAM 0 B 84.95 KB 448 KB
ROM -184 B 414.75 KB 1008 KB
nrf54l15pdk_nrf54l15_cpuapp:sample.sidewalk.demo RAM 0 B 97.69 KB 256 KB
ROM -8 B 351.45 KB 730 KB
nrf54l15pdk_nrf54l15_cpuapp:sample.sidewalk.demo.ble_only RAM 0 B 97.69 KB 256 KB
ROM -8 B 351.2 KB 730 KB

Copy link
Contributor

@totyz totyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still see <inf> app_tx: Capability send or similar in Demo app in DFU mode

CONF_FILE is a list

Signed-off-by: Krzysztof Taborowski <[email protected]>
[KRKNWK-18489]

Signed-off-by: Krzysztof Taborowski <[email protected]>
[KRKNWK-18777]

Signed-off-by: Krzysztof Taborowski <[email protected]>
[KRKNWK-18804]

Signed-off-by: Krzysztof Taborowski <[email protected]>
Copy link
Contributor

@totyz totyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ktaborowski ktaborowski merged commit 5ecca2c into nrfconnect:main Apr 11, 2024
56 checks passed
@ktaborowski ktaborowski deleted the logs-quick-fix branch April 16, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source PR changing src files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants