Skip to content

Commit

Permalink
kconfig: don't 'select' ZCBOR
Browse files Browse the repository at this point in the history
When an option depends on another option being set, its definition
should use 'depends on' - not 'select'.

Using 'select' introduces a two way dependency which makes
it impossible to express proper kconfig dependencies in some
cases.

See 'select pitfalls' chapter in zephyr documentation for details.

Ref: NCSDK-27818

Signed-off-by: Håkon Amundsen <[email protected]>
  • Loading branch information
hakonfam committed Jun 6, 2024
1 parent 35461fb commit c2a804c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions nrf_rpc/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ if NRF_RPC
config NRF_RPC_CBOR
bool "Add CBOR layer"
default y
select ZCBOR
select ZCBOR_STOP_ON_ERROR
depends on ZCBOR
depends on ZCBOR_STOP_ON_ERROR
help
Adds API that helps use of CBOR library for data serialization.

Expand Down

0 comments on commit c2a804c

Please sign in to comment.